New issue
Advanced search Search tips

Issue 890755 link

Starred by 1 user
Status: Fixed
Owner:
f...@opera.com
Closed: Oct 2
Cc:
robertma@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[WPT] New failures introduced in external/wpt/css/css-masking by import https://crrev.com/c/1254241

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Oct 1 
WPT import https://crrev.com/c/1254241 introduced new failures in external/wpt/css/css-masking:

List of new failures:
external/wpt/css/css-masking/mask-svg-content/mask-text-001.svg [ Failure ]

This import contains upstream changes from ee2e69bfb1d44c4013a8ce94ca6932f86d63aa31 to 73f9d4eee50af8634368a9bcbf5095a524290489:
Tests for scaled content with masks and mask-type property: https://github.com/web-platform-tests/wpt/commit/73f9d4eee50af8634368a9bcbf5095a524290489 [affecting this directory]
Make wptrunner chrome always use the WebDriver executor: https://github.com/web-platform-tests/wpt/commit/caf4aa367efef641c4b0e5dfd1c8970eb102f060
Unknown executor exceptions need be INTERNAL-ERROR: https://github.com/web-platform-tests/wpt/commit/40421ff058cbf8020878bcb096bf604d1c450aec
CSS Paths: fix horizontal/vertical commands: https://github.com/web-platform-tests/wpt/commit/f95086e8eba4d14041e67e7bb147345d1d38a22f [affecting this directory]
Allow all pull requests to trigger Taskcluster (#13282): https://github.com/web-platform-tests/wpt/commit/207fa91e8016fcb650e4869e0da6ef036d7671b3
ServiceWorker: Implement to return registration data after evaluate module scripts, and add WPT tests for ServiceWorker module scripts: https://github.com/web-platform-tests/wpt/commit/0c9042da11fa00e2df7d3115b7629a65a5d0fee9

Comment 1 by f...@opera.com, Oct 1

Status: Available (was: Untriaged)
At a glance it looks like the ref is incorrect (lacking dimensions thus does not clip.)

Comment 2 by f...@opera.com, Oct 2

Owner: f...@opera.com
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc12f84a3a46e21259f18a0074653084ba6fa77d

commit dc12f84a3a46e21259f18a0074653084ba6fa77d
Author: Fredrik Söderquist <fs@opera.com>
Date: Tue Oct 02 19:00:29 2018

Fix wpt/css/css-masking/mask-svg-content/mask-text-001.svg

The test has fixed dimensions of 100x100 pixels - the reference does
not. Add same fixed dimensions to the reference to get the same clipping
behavior.

Bug:  890755 
Change-Id: Ib3d12ad1f7ace05027b81b9c683158490ae116ab
Reviewed-on: https://chromium-review.googlesource.com/1256568
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#595936}
[modify] https://crrev.com/dc12f84a3a46e21259f18a0074653084ba6fa77d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/dc12f84a3a46e21259f18a0074653084ba6fa77d/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/mask-svg-content/reference/mask-text-001-ref.svg

Comment 4 by f...@opera.com, Oct 2

Status: Fixed (was: Assigned)
►

Sign in to add a comment