Issue metadata
Sign in to add a comment
|
44 kb regression in resource_sizes (MonochromePublic.apk) at 595190:595191 |
||||||||||||||||||||
Issue descriptionCaused by “RTCQuicTransport: start() implementation” Commit: 9003d89c3b423e96556dfaba58ce62a596bc3fe0 Link to size graph: https://chromeperf.appspot.com/report?sid=bb23072657e2d7ca892a1c3fa4643b1ee29b3a0a44d0732adda87168e89c0380&num_points=10&rev=595191 Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase Based on the graph: Native code growth. Interactive Supersize diff: https://storage.googleapis.com/chrome-supersize/viewer.html?load_url=https%3A%2F%2Fstorage.googleapis.com%2Fchromium-binary-size-trybot-results%2Fandroid-binary-size%2F2018%2F09%2F28%2F64943.ndjson&diff_mode=on
,
Oct 1
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8933859950295285872
,
Oct 1
It's not clear to me whether or not this increase was expected. Please have a look and either: 1. Close as “Won't Fix” with a short justification, or 2. Land a revert / fix-up.
,
Oct 1
Hi, I'm trying to run `tools/binary_size/diagnose_bloat.py 9003d89c3b423e96556dfaba58ce62a596bc3fe0 --cloud` to diagnose this further, but I'm getting this result: I 31 Processing 2 commits I 3095 Downloading build artifacts for c02251d23a5d96962aec9f0c2e92bb5909fb757c E 4257 Failure: Unexpected error while downloading gs://chrome-perf/Android Builder/full-build-linux_c02251d23a5d96962aec9f0c2e92bb5909fb757c.zip. It may no longer exist on the server or it may not have been uploaded yet (check https://build.chromium.org/p/chromium.perf/builders/Android%20Builder). Otherwise, you may not have the correct access permissions. Process output: ServiceException: 401 Anonymous caller does not have storage.objects.get access to chrome-perf/Android Builder/full-build-linux_c02251d23a5d96962aec9f0c2e92bb5909fb757c.zip. Do you know what I need to configure / who to contact to get this to work?
,
Oct 3
Try running "gsutil.py config" to authenticate (one time step). It's probably even more useful / easier to look a the binary size trybot result for the change: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-binary-size/64943 (need to click on "show experimental" to have the bot show up. The bot was made non-experimental shortly after your change :P)
,
Oct 3
OK, I think this is expected. Most of the binary size is from the Blink bindings that were landed (~10k) and components of the net/third_party/quic library (~30k). Chrome already pulls in most of net/third_party/quic. The increase here is because we set up both sides of a QUIC connection (client & server) to support peer-to-peer use cases, so now the QUIC server-side components are also included in the binary rather than just the client-side components. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 1