New issue
Advanced search Search tips

Issue 890750 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Inconsistent latency handling in input_router_impl.cc

Reported by i...@vivaldi.com, Oct 1

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.102 Safari/537.36 Vivaldi/2.0.1314.10000

Steps to reproduce the problem:
InputRouterImpl implementation handles latency inconsistently, https://chromium.googlesource.com/chromium/src.git/+/master/content/browser/renderer_host/input/input_router_impl.cc

First *Handled callbacks like KeyboardEventHandled contains the code: event.latency.AddNewLatencyFrom(latency). But FilterAndSendWebInputEvent may call the callback directly passing the original latency as the latency argument. As the result the latency is doubled. 

Another problem is that the code sometimes uses the adjusted latency, like MouseWheelEventHandled that passes event.latency to the wheel and touch queues while other *Handled methods passes the latency argument.  

What is the expected behavior?

What went wrong?
I suppose the latency adjustment code should be replaced with something like event.latency = latency as the latency argument should already contain the accumulated latency and then the code can always just use the latency argument.

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: master  Channel: dev
OS Version: 10.0
Flash Version:
 
Labels: Needs-Triage-M69
Components: Blink>Input
Cc: bokan@chromium.org
Owner: sahel@chromium.org
Status: Assigned (was: Unconfirmed)
Sounds like this could affect our latency tracking. Sahel, please take a look when you're done with the more urgent current work.

Sign in to add a comment