New issue
Advanced search Search tips

Issue 890749 link

Starred by 1 user
Status: WontFix
Owner:
petewil@chromium.org
Closed: Oct 1
Cc:
estevenson@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

16 kb regression in resource_sizes (MonochromePublic.apk) at 594589:594589

Project Member Reported by estevenson@chromium.org, Oct 1 
Caused by “Get the catalog from the network”

Commit: fce6b968877de9af18be072706b52babbfbaaad5

Link to size graph: https://chromeperf.appspot.com/report?sid=bb23072657e2d7ca892a1c3fa4643b1ee29b3a0a44d0732adda87168e89c0380&num_points=10&rev=594589 

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Based on the graph: Native code growth mostly due to protobuf usage
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 1 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=890749

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=5397071e5c1c2abd62f0927aaddf7576af903b04ec28e4db22d0460dcb68555b


Bot(s) for this bug's original alert(s):

Android Builder Perf
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Oct 1

Owner: petewil@chromium.org
Status: Assigned (was: Untriaged)
Assigning to petewil@chromium.org because this is the only CL in range:
Get the catalog from the network

Uses the ExploreSitesFetcher to get the latest catalog from the network,
and upload it into our database for use on next run of ExploreSites.

Bug:  889104 
Change-Id: I2d414e6cea59271252fa735bd59191706dead377
Reviewed-on: https://chromium-review.googlesource.com/1243673
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594589}

Comment 3 by estevenson@chromium.org, Oct 1 

See the attached diff for debugging.

It looks to me that the size increase is expected.
Feel free to close as “Won't Fix” unless you can see some way to reduce size.
diff_results.txt
111 KB View Download

Comment 4 by petewil@chromium.org, Oct 1

Status: WontFix (was: Assigned)
This is all code size increase, and is expected when dealing with protobufs.
►

Sign in to add a comment