New issue
Advanced search Search tips

Issue 890720 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'You can only have up to 5 accounts for Multiple sign-in' message is seen missing after adding 5 Accounts for Multiple sign-in at Uber Tray

Project Member Reported by mmanchala@chromium.org, Oct 1

Issue description

Chrome Version:  71.0.3565.0/11116.0.0 dev channel Daisy,Kip and Reks
OS: Chrome

Pre-condition : Add 4-5 Users

What steps will reproduce the problem?
1)Sign in to user-> logout -> sign in to another user-> Go to Uber tray -> click on user I'd and select 'Sign in to another user...' option for Multiple sign-in
2)Add upto 4 users for Multiple Sign-in -> Now at Uber Tray click on Profile picture and observe for 'You can only have up to 5 accounts for Multiple sign-in' message 
(Please refer Video and Screenshot)

Expected:  'You can only have up to 5 accounts for Multiple sign-in' message should be seen after adding 5 Accounts for Multiple sign-in
Actual: Instead No Message is seen

This is Regression Issue as same is working fine in M-69

Note : Issue is also seen on M-70 

 
Actual_NoMessage.mp4
5.1 MB View Download
Actual_NoMessage.jpg
714 KB View Download
Expected_Message.jpg
825 KB View Download
Cc: -tetsui@chromium.org sgabr...@chromium.org
Owner: tetsui@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
+sgabriel@ for confirmation

I implemented this and will land it soon, but this feature is missing from UX spec.
If UX want to tweak the messages / paddings, please let me know.
Screenshot 2018-10-02 at 3.54.54 PM.png
14.8 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f831f83192ac398efdde6ea0e10d9eaaf6a4c70

commit 7f831f83192ac398efdde6ea0e10d9eaaf6a4c70
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Tue Oct 02 08:44:35 2018

Unified: Fix user chooser minor issues.

This CL fixes two issues related to UserChooserView in
UnifiedSystemTray.
* Ensure the UnifiedSystemTray bubble is expanded before showing
  UserChooserView.
* Show error messages when number of added users reaches the limit.

BUG= 890720 , 890722 
TEST=manual

Change-Id: I2ea7c807da18e165f66345e50b9c6cf39e954840
Reviewed-on: https://chromium-review.googlesource.com/1255745
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595760}
[modify] https://crrev.com/7f831f83192ac398efdde6ea0e10d9eaaf6a4c70/ash/system/unified/unified_system_tray_controller.cc
[modify] https://crrev.com/7f831f83192ac398efdde6ea0e10d9eaaf6a4c70/ash/system/unified/user_chooser_view.cc

Status: Fixed (was: Started)

Sign in to add a comment