New issue
Advanced search Search tips

Issue 890710 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Translate login_Cryptohome* tests to tast.

Project Member Reported by hidehiko@chromium.org, Oct 1

Issue description

This is the tracking issue.
The targets are:
- login_Cryptohome
- login_CryptohomeIncognito
 
Just note: More tests can be added after  crbug.com/889776 .
At the moment, those new tests are out of scope.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/9b2cfae4e213c1bfcdcec8a557b91a90ede08fe9

commit 9b2cfae4e213c1bfcdcec8a557b91a90ede08fe9
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Oct 02 20:23:03 2018

tast-test: Update cryptohome mount condition check.

This is to catch up with the existing mount check in autotest.
The goal is to port more cryptohome related from autotest to tast,
and in the new tests, the utilities (findPartition, validatePartition)
will be reused.

cf)
- https://chromium.git.corp.google.com/chromiumos/third_party/autotest/+/master/client/cros/cryptohome.py#432
- https://chromium.git.corp.google.com/chromiumos/third_party/autotest/+/master/client/cros/cryptohome.py#494

BUG= chromium:890710 
TEST=Ran ui.ChromeLogin on DUT.

Change-Id: I777b0038e2a4fd43a1ad4f64c396948073771bee
Reviewed-on: https://chromium-review.googlesource.com/1253961
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

[modify] https://crrev.com/9b2cfae4e213c1bfcdcec8a557b91a90ede08fe9/src/chromiumos/tast/local/cryptohome/cryptohome.go

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/dd90ae2a102c0de83c195c7a8bb2971c9867c1a6

commit dd90ae2a102c0de83c195c7a8bb2971c9867c1a6
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Oct 31 15:17:28 2018

tast-test: Improve test failure message.

BUG= chromium:890710 
TEST=Ran on DUT.

Change-Id: Ifbe3965157faca16abcf01cbc876cdb9e25e7323
Reviewed-on: https://chromium-review.googlesource.com/1309438
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/dd90ae2a102c0de83c195c7a8bb2971c9867c1a6/src/chromiumos/tast/local/bundles/cros/cryptohome/login.go

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/1a34c580832324071e311521a69b44f4a167cb3e

commit 1a34c580832324071e311521a69b44f4a167cb3e
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Nov 01 04:59:23 2018

tast-test: Port login_CryptohomeIncognito.

Along with the test porting, this CL implements;
- Guest Chrome login.
- Support guest user in cryptohome mount validation.

BUG= chromium:890710 
TEST=Ran on DUT.

Change-Id: Ibc5e24f56dcf93bda5256f6318bfc76820caa88a
Reviewed-on: https://chromium-review.googlesource.com/1303785
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

[add] https://crrev.com/1a34c580832324071e311521a69b44f4a167cb3e/src/chromiumos/tast/local/bundles/cros/cryptohome/login_guest.go
[modify] https://crrev.com/1a34c580832324071e311521a69b44f4a167cb3e/src/chromiumos/tast/local/cryptohome/cryptohome.go
[modify] https://crrev.com/1a34c580832324071e311521a69b44f4a167cb3e/src/chromiumos/tast/local/chrome/chrome.go

Status: Fixed (was: Started)
Done for CQ cryptohome tests.

Sign in to add a comment