Issue metadata
Sign in to add a comment
|
Regression:Black glimpse with transparent zone underneath is seen for play store window in overview mode |
||||||||||||||||||||||
Issue descriptionChrome Version:71.0.3565.0/11116.0.0 dev channel Reks OS:Chrome OS What steps will reproduce the problem? (1)Sign into user >>Open play store window (2)Keep it in overview mode and observe its bottom edge Actual: Black glimpse with transparent zone underneath is seen for play store window in overview mode Expected: Instead no such black glimpse with transparent division should be seen at at bottom edge play store window in overview mode This is a Regression issue as same is working fine in 71.0.3562.0/11107.0.0 dev Attached the screencast for reference.. Note: Issue is not seen in Linux,Windows,other non-ARC devices
,
Oct 17
Andrew, can you run bisect? Here is the regression range. https://chromium.googlesource.com/chromium/src/+log/71.0.3562.0..71.0.3565.0?n=10000
,
Oct 18
5ccc1e0311b53a7acc92d5e2f3c95a50ac39bb06 is the first bad commit commit 5ccc1e0311b53a7acc92d5e2f3c95a50ac39bb06 Author: Eliot Courtney <edcourtney@google.com> Date: Fri Sep 28 02:36:28 2018 +0000 Apply rounded corners to the Picture-in-Picture window. stayed upon resizing the window. Bug: b/112668689 Bug: 841886 Test: Created a PIP window and it had rounded corners. Rounded corners Change-Id: Ie57223d8c5a2701a0013eee0bce2cf5333d2c304 Reviewed-on: https://chromium-review.googlesource.com/1219426 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#594962} :040000 040000 a5b39d67d3d763181bb4c8a532fcf83a6b294bc4 aeb64b7a09a1b71f96a8c75e6997d91d6abf9d77 M ash
,
Oct 25
Eliot, can you take a look?
,
Oct 25
Sure, let me have a look.
,
Oct 25
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60a782a13a4806537be223a6bc8cee5e374caaf7 commit 60a782a13a4806537be223a6bc8cee5e374caaf7 Author: Eliot Courtney <edcourtney@google.com> Date: Thu Oct 25 04:13:28 2018 Only remove PIP layer mask if it is actually the PIP layer mask. mask applied to it. Bug: 890706 Test: Try play store in the overview mode, it correctly has the overview Change-Id: Ief07667a66479fbcd12b1a87c7c11778a3d9eccf Reviewed-on: https://chromium-review.googlesource.com/c/1298519 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#602608} [modify] https://crrev.com/60a782a13a4806537be223a6bc8cee5e374caaf7/ash/wm/window_state.cc
,
Oct 25
Requesting merge to M-71~ Thanks~!
,
Oct 25
Assumed this is verified as fixed?
,
Oct 26
Sorry, forgot to mark as fixed. I tested it and verified that the black bar during overview mode is gone, and rounded corners properly applies in overview mode.
,
Oct 26
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 26
Approving merge to M71 Chrome OS.
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c4a1c112aa9cf73dad704d283b7217622a89bb1 commit 8c4a1c112aa9cf73dad704d283b7217622a89bb1 Author: Eliot Courtney <edcourtney@google.com> Date: Tue Oct 30 09:49:40 2018 Only remove PIP layer mask if it is actually the PIP layer mask. mask applied to it. Bug: 890706 Test: Try play store in the overview mode, it correctly has the overview Change-Id: Ief07667a66479fbcd12b1a87c7c11778a3d9eccf Reviewed-on: https://chromium-review.googlesource.com/c/1298519 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602608}(cherry picked from commit 60a782a13a4806537be223a6bc8cee5e374caaf7) Reviewed-on: https://chromium-review.googlesource.com/c/1307356 Reviewed-by: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#385} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/8c4a1c112aa9cf73dad704d283b7217622a89bb1/ash/wm/window_state.cc
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c4a1c112aa9cf73dad704d283b7217622a89bb1 Commit: 8c4a1c112aa9cf73dad704d283b7217622a89bb1 Author: edcourtney@google.com Commiter: edcourtney@chromium.org Date: 2018-10-30 09:49:40 +0000 UTC Only remove PIP layer mask if it is actually the PIP layer mask. mask applied to it. Bug: 890706 Test: Try play store in the overview mode, it correctly has the overview Change-Id: Ief07667a66479fbcd12b1a87c7c11778a3d9eccf Reviewed-on: https://chromium-review.googlesource.com/c/1298519 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602608}(cherry picked from commit 60a782a13a4806537be223a6bc8cee5e374caaf7) Reviewed-on: https://chromium-review.googlesource.com/c/1307356 Reviewed-by: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#385} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by afakhry@chromium.org
, Oct 17Owner: osh...@chromium.org