New issue
Advanced search Search tips

Issue 890700 link

Starred by 1 user
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Oct 3
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] Print Destination 'Icons' appears small in size after resizing the browser window.

Reported by sanyam.g...@etouch.net, Oct 1 
Chrome Version : 71.0.3567.0 (Official Build) Revision	7c7bc73fc5f252e28f2308c81de4760e49990542-refs/branch-heads/3567@{#1} (32/64 bit)
OS :Windows (7, 8, 8.1 ,10), Mac(10.12.6, 10.13.1, 10.14, 10.13.6) and Linux 14.04 LTS

Pre-condition: Ensure that few printer entries are seen under 'Print Destination'.

Steps to reproduce:
1. Launch chrome and navigate to 'chrome://settings/appearance'
2. Change the Font size to 'Large' or 'Very Large' and give print command.
3. Click on 'Change' button to open the 'Select a destination' overlay.
4. Resize the browser and observe the Print icons under Print Destination.

Actual Result  : Print Destination 'Icons' appears small in size after resizing the browser window.
Expected Result: Print Destination 'Icons' should not appear small in size after resizing the browser window.

This is a regression issue broken in ‘M-71’ and providing the bisect info below:
Good Build : 71.0.3551.3 (Revision : 590851)
Bad Build  : 71.0.3552.2 (Revision : 591210)

CHANGE-LOG URL:
https://chromium.googlesource.com/chromium/src/+log/71.0.3551.0..71.0.3552.0?pretty=fuller&n=10000

Suspecting : r591109 ?

@rbpotter : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
(Unable to provide bisect using 1) Per-revision script as Traceback error message is thrown and 
 			        2) Chromium bisect script as unable to login into chromium builds..
Also, tried bisecting on multiple machines and same error is seen. Hence, providing suspect manually from change-log)

Kindly refer the attached screen-cast.

Thank you..!
Actual_Result.mp4
3.2 MB View Download
Expected_Result.mp4
3.5 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecd2d92d7b10e92cbf575862c9a9d3551062b26b

commit ecd2d92d7b10e92cbf575862c9a9d3551062b26b
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Oct 02 01:04:56 2018

Print Preview Refresh: fix destinations icon issue

(1) Fix an issue where icons were shrinking with browser window size
(2) Related: To make the fact that the destination-list-item uses
    display:flex more clear, move all styling for this item into its
    own HTML file, rather than splitting with its parent list.
(3) Remove margin which was not needed since the item uses padding.
(4) Ensure max-height never gets set below min-height, and set a
    min-height for the list container.

Bug:  890700 
Change-Id: I4f91e43024faea494dbc5a48f6590ca3b863136e
Reviewed-on: https://chromium-review.googlesource.com/1256004
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595673}
[modify] https://crrev.com/ecd2d92d7b10e92cbf575862c9a9d3551062b26b/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/ecd2d92d7b10e92cbf575862c9a9d3551062b26b/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/ecd2d92d7b10e92cbf575862c9a9d3551062b26b/chrome/browser/resources/print_preview/new/destination_list.js
[modify] https://crrev.com/ecd2d92d7b10e92cbf575862c9a9d3551062b26b/chrome/browser/resources/print_preview/new/destination_list_item.html

Comment 2 by sanyam.g...@etouch.net, Oct 3

Labels: TE-Verified-M71 TE-Verified-71.0.3569.0
Update :

Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) OS with Canary version #71.0.3569.0 and the issue is fixed.

Kindly refer the attached screen cast.
Fixed_Behaviour.mp4
1.6 MB View Download

Comment 3 by rbpotter@chromium.org, Oct 3

Status: Verified (was: Assigned)
►

Sign in to add a comment