Merge user services for soundwave and pinpoint_cli |
|||
Issue descriptionThis will allow to have a self contained services module with API accesses to dashboard services which command line tools can reuse.
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92ddcef22979298054283376d22b64241a1ee44b commit 92ddcef22979298054283376d22b64241a1ee44b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Oct 19 11:35:57 2018 Roll src/third_party/catapult 2f3bd7e85ec6..f608aa22d174 (2 commits) https://chromium.googlesource.com/catapult.git/+log/2f3bd7e85ec6..f608aa22d174 git log 2f3bd7e85ec6..f608aa22d174 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 perezju@chromium.org [soundwave] Add dashboard_service module 2018-10-19 perezju@chromium.org [soundwave] Add timeseries --output-csv option Created with: gclient setdep -r src/third_party/catapult@f608aa22d174 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:890691 , chromium:894773 , chromium:879526 TBR=sullivan@chromium.org Change-Id: Ie326b24cd52919b8620f0907de755467ef428687 Reviewed-on: https://chromium-review.googlesource.com/c/1290784 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601114} [modify] https://crrev.com/92ddcef22979298054283376d22b64241a1ee44b/DEPS
,
Oct 23
+benjhayden
I was looking into this, hoping to take the change to upgrade soundwave's use of the dashboard APIs to their v2 version (i.e. /describe and /timeseries2).
However I think there is no equivalent for /api/list_timeseries/{benchmark} which also takes a sheriff parameter to get the monitored timeseries for a given sheriff rotation.
I could keep using this endpoint until an alternative is implemented, but then how should I translate the test_paths it returns this into (measurement, bot, test_case, test_suite) values suitable for /timeseries2 ?
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/7b6a59fda6b64aeddfdfb52d6abf0be7c296f3fb commit 7b6a59fda6b64aeddfdfb52d6abf0be7c296f3fb Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Wed Oct 24 12:45:19 2018 [soundwave] Move ListTestPaths to services.dashboard Bug: chromium:890691 Change-Id: I87a6759c3b5f56f4b9715235c943b6a8ef19db09 Reviewed-on: https://chromium-review.googlesource.com/c/1296552 Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/7b6a59fda6b64aeddfdfb52d6abf0be7c296f3fb/experimental/soundwave/services/dashboard_service.py [modify] https://crrev.com/7b6a59fda6b64aeddfdfb52d6abf0be7c296f3fb/experimental/soundwave/soundwave/dashboard_api.py [modify] https://crrev.com/7b6a59fda6b64aeddfdfb52d6abf0be7c296f3fb/experimental/soundwave/soundwave/commands.py [modify] https://crrev.com/7b6a59fda6b64aeddfdfb52d6abf0be7c296f3fb/experimental/soundwave/services/dashboard_service_test.py
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab9d4a56ab31dc5783e56027e993d87125d45b96 commit ab9d4a56ab31dc5783e56027e993d87125d45b96 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Oct 24 13:46:27 2018 Roll src/third_party/catapult 38b827049c96..7b6a59fda6b6 (1 commits) https://chromium.googlesource.com/catapult.git/+log/38b827049c96..7b6a59fda6b6 git log 38b827049c96..7b6a59fda6b6 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 perezju@chromium.org [soundwave] Move ListTestPaths to services.dashboard Created with: gclient setdep -r src/third_party/catapult@7b6a59fda6b6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:890691 TBR=sullivan@chromium.org Change-Id: I5a3be93243967dd0c9429b07cfeee80e790afbb1 Reviewed-on: https://chromium-review.googlesource.com/c/1297343 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602320} [modify] https://crrev.com/ab9d4a56ab31dc5783e56027e993d87125d45b96/DEPS
,
Oct 30
Ping benjhayden Re #3?
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/33de248bd672b01796c39bdda4d30933db3adb9b commit 33de248bd672b01796c39bdda4d30933db3adb9b Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Tue Nov 27 11:36:45 2018 [soundwave] Move timeseries (v1) API to dashboard_services Continue with the migration out of soundwave.dashboard_api and into the more general services.dashboard_services. Take the chance to improve the docstring and tests for Timeseries2 too. Bug: chromium:890691 Change-Id: Ia2b64794f15361d3b8edf82d591cb66b3ab0fb0c Reviewed-on: https://chromium-review.googlesource.com/c/1349359 Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/33de248bd672b01796c39bdda4d30933db3adb9b/experimental/soundwave/services/dashboard_service.py [modify] https://crrev.com/33de248bd672b01796c39bdda4d30933db3adb9b/experimental/soundwave/soundwave/dashboard_api.py [modify] https://crrev.com/33de248bd672b01796c39bdda4d30933db3adb9b/experimental/soundwave/soundwave/commands.py [modify] https://crrev.com/33de248bd672b01796c39bdda4d30933db3adb9b/experimental/soundwave/services/dashboard_service_test.py [delete] https://crrev.com/3dc39538bcf5293fce798740c9e583ceba96fadc/experimental/soundwave/soundwave/dashboard_api_test.py
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/6bc44f15f2542ba537345fe26af146023988642c commit 6bc44f15f2542ba537345fe26af146023988642c Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Tue Nov 27 16:05:25 2018 [soundwave] Finish merging soundwave.dashboard_api into dashboard_service We move the last two pieces of soundwave.dashboard_api into the more general services.dashboard_service, while adding some more test coverage. Bug: chromium:890691 Change-Id: I1e0ccd01a4c696d535168257168e3f833c4fa512 Reviewed-on: https://chromium-review.googlesource.com/c/1349361 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Ben Hayden <benjhayden@chromium.org> [modify] https://crrev.com/6bc44f15f2542ba537345fe26af146023988642c/experimental/soundwave/services/dashboard_service.py [delete] https://crrev.com/33de248bd672b01796c39bdda4d30933db3adb9b/experimental/soundwave/soundwave/dashboard_api.py [modify] https://crrev.com/6bc44f15f2542ba537345fe26af146023988642c/experimental/soundwave/soundwave/commands.py [modify] https://crrev.com/6bc44f15f2542ba537345fe26af146023988642c/experimental/soundwave/services/dashboard_service_test.py
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45d1d8f7d0d019f4f5183231700a6df2dccf2b6b commit 45d1d8f7d0d019f4f5183231700a6df2dccf2b6b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Nov 28 18:22:13 2018 Roll src/third_party/catapult 17079a5cc1f2..6457c042bc7b (4 commits) https://chromium.googlesource.com/catapult.git/+log/17079a5cc1f2..6457c042bc7b git log 17079a5cc1f2..6457c042bc7b --date=short --no-merges --format='%ad %ae %s' 2018-11-27 bpastene@chromium.org devil: When setting flags on the device, log the file location. 2018-11-27 perezju@chromium.org [soundwave] Finish merging soundwave.dashboard_api into dashboard_service 2018-11-27 perezju@chromium.org [soundwave] Move timeseries (v1) API to dashboard_services 2018-11-26 eyaich@google.com Create method to add shared diagnostics to histograms not created through tbmv2 Created with: gclient setdep -r src/third_party/catapult@6457c042bc7b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:907899, chromium:890691 , chromium:890691 ,chromium:714231 TBR=sullivan@chromium.org Change-Id: Ib6bd9c1d01e778e980d316e2889cc6a3f92d315d Reviewed-on: https://chromium-review.googlesource.com/c/1352712 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611782} [modify] https://crrev.com/45d1d8f7d0d019f4f5183231700a6df2dccf2b6b/DEPS
,
Nov 29
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Oct 19