Remove ash::Shell::{Enable,Disable}Keyboard from ArcInputMethodManagerService. |
||
Issue descriptionThis issue is related to crbug.com/826391 ArcInputMethodManagerService enables/disables Chrome OS's VK when Android IME is activated/deactivated. There is a similar pattern in ChromeLauncherController, so it might be good to support enabling/disabling VK from chrome/ code. My current idea is like the following: 1. adding a mojom interface for ash/keyboard/virtual_keyboard_controller.h 2. adding a method to override VK availability to the new interface. The new method should call ash::Shell::EnableKeyboard() or ash::Shell::DisableKeyboard() if VK availability is changed by the call. 3. calling it from both of ChromeLauncherController and ArcInputMethodManagerService. The new method has to call ash::Shell::{Enable, Disable}Keyboard, so I think ash::VirtualKeyboardController should have the method instead of keyboard::KeyboardController.
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b381a67a876ee0cbd362b42c9f40775a30ba5773 commit b381a67a876ee0cbd362b42c9f40775a30ba5773 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Wed Oct 03 06:23:18 2018 Do not show fallback keyboard when Android IME is active. Chrome OS provides the fallback virtual keyboard for IMEs that provide their own HTML-based virtual keyboard. It's not useful for ARC IMEs because their UI is based on Android's View. This CL disables the fallback virtual keyboard while an ARC IME is active. Bug: 845079, 890677 Test: unit_tests Change-Id: I9a799cf049c886cdc25f7ae04a97d716e38338ea Reviewed-on: https://chromium-review.googlesource.com/c/1253318 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#596133} [add] https://crrev.com/b381a67a876ee0cbd362b42c9f40775a30ba5773/chrome/browser/chromeos/arc/input_method_manager/DEPS [modify] https://crrev.com/b381a67a876ee0cbd362b42c9f40775a30ba5773/chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service.cc [modify] https://crrev.com/b381a67a876ee0cbd362b42c9f40775a30ba5773/chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service_unittest.cc
,
Oct 22
This is resolved by crrev.com/c/1291350. Thank you, Steven! |
||
►
Sign in to add a comment |
||
Comment 1 by yhanada@chromium.org
, Oct 1