New issue
Advanced search Search tips

Issue 890670 link

Starred by 2 users
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Oct 4
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessarily 'All' option gets selected upon deleting invalid input from the 'Custom' text box.

Reported by avsha...@etouch.net, Oct 1 
Chrome Version : 71.0.3566.0 (Official Build) a352a9889d05931a37d3182669913d546b3b35e7-refs/branch-heads/3566@{#1} 32/64 bit
OS : Windows(7, 8, 8.1 ,10), Mac(10.12.6, 10.13.1, 10.14, 10.13.6), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, open NTP and hit 'Ctrl + P' to open print preview.
2. Select printer from the 'Destination' list and enter '9' in 'Custom' text box.
3. Delete this input using 'Space bar' and observe the radio button.

Actual Result : Unnecessarily 'All' option gets selected upon deleting invalid input from the 'Custom' text box. (i.e 'All' option gets selected before user can enter a valid input in 'Custom' field) 

Expected Result : Text caret should remain in 'Custom' text box upon deleting the invalid input from 'Custom' text box (So that user can erase wrong input and put in a correct number)

This is a regression issue broken in ‘M-71’ and below is the 'Chromium bisect' information:
Good Build : 71.0.3564.0 (Revision : 594950)
Bad Build : 71.0.3565.0 (Revision : 595251)

Chromium bisect URL:
https://chromium.googlesource.com/chromium/src/+log/44a2e6f192177bd280e7aaec12bfdd20f2cf6641..9b7e8547498ccb8cf22490e5b2387c142216cfc9

Suspect: r594974

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. This issue is seen only when wrong input is entered in custom field step 2.
2. Unable to provide 'per-revision' bisect as it shows "We don't have enough builds to bisect" error message.
3. Tried on other machines but still getting the same error again.
4. Hence provided suspect through 'Chromium bisect'

Thank you..!
Actual_Result.mp4
535 KB View Download
Expected_Result.mp4
481 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5bada71165d069e7f117fc8c8011f4b8fb5902c

commit e5bada71165d069e7f117fc8c8011f4b8fb5902c
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Oct 03 02:02:52 2018

Print Preview Refresh: Fix a bug with pages settings

Ensure that all is not reselected when an invalid input is cleared.
Similar to scaling, achieve this by not resetting the backing pages
value (or its validity) when an invalid input is cleared. This also
saves a preview refresh.

Also adding tests for some pages behaviors from this and prior CLs.

Bug:  890670 
Change-Id: I34285b311f7abd0c992557151f90867cd36cb375
Reviewed-on: https://chromium-review.googlesource.com/c/1256624
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596093}
[modify] https://crrev.com/e5bada71165d069e7f117fc8c8011f4b8fb5902c/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/e5bada71165d069e7f117fc8c8011f4b8fb5902c/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/e5bada71165d069e7f117fc8c8011f4b8fb5902c/chrome/test/data/webui/print_preview/pages_settings_test.js
[modify] https://crrev.com/e5bada71165d069e7f117fc8c8011f4b8fb5902c/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js

Comment 2 by rbpotter@chromium.org, Oct 4

Status: Fixed (was: Assigned)
►

Sign in to add a comment