New issue
Advanced search Search tips

Issue 890656 link

Starred by 1 user
Status: Fixed
Owner:
acourbot@chromium.org
Closed: Oct 1
Cc:
posciak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

VDA unittest failing on V4L2 platforms if rendering disabled

Project Member Reported by acourbot@chromium.org, Oct 1 
./video_decode_accelerator_unittest --single-process-tests --disable_rendering --test_video_data=test-25fps.h264:320:240:250:258:35:150:1 --gtest_filter="*TestDecodeTimeMedian*"
...
[5251:5259:1001/131627.278620:1124707364:FATAL:v4l2_video_decode_accelerator.cc(1507)] Check failed: output_record.picture_id != -1 (-1 vs. -1)

This was introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1170707.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d87cc31299751c450c5e44c68ea650c8ff453dfb

commit d87cc31299751c450c5e44c68ea650c8ff453dfb
Author: Alexandre Courbot <acourbot@chromium.org>
Date: Mon Oct 01 05:01:48 2018

media/gpu/v4l2vda: Fix buffers assignment sequence.

CL 1170707 has introduced an issue when we disable rendering on the VDA
unittest: ImportBufferForPictureTask() would be called from
AssignPictureBuffersTask() while buffers were still in the free list,
resulting in EnqueueOutputRecord() trying to enqueue buffers that had
still not received a picture ID.

Fix this by first acquiring all buffers, before iterating on them and
calling ImportBufferForPictureTask().

BUG= 890656 
TEST=Checked the VDA unittest passed on Hana and Cheza, with rendering
both disabled and enabled.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ied75af6d4503ff5e57b1b6bc9d2a0e1d3c2fca89
Reviewed-on: https://chromium-review.googlesource.com/1252228
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595383}
[modify] https://crrev.com/d87cc31299751c450c5e44c68ea650c8ff453dfb/media/gpu/v4l2/v4l2_video_decode_accelerator.cc

Comment 2 by acourbot@chromium.org, Oct 1

Status: Fixed (was: Started)
►

Sign in to add a comment