New issue
Advanced search Search tips

Issue 890649 link

Starred by 6 users
Status: Fixed
Owner:
joelhockey@chromium.org
Closed: Oct 24
Cc:
tbuck...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Please support Google Drive access inside the Linux Container

Reported by edurmac...@gmail.com, Oct 1 
UserAgent: Mozilla/5.0 (X11; CrOS x86_64 11021.28.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.34 Safari/537.36
Platform: 11021.28.0 (Official Build) beta-channel eve

Steps to reproduce the problem:
1. Open linux terminal and/or any linux app
2. Try to access/save files in Google Drive

What is the expected behavior?

What went wrong?
Linux container has no access to the Google Drive folder. 
Considering the nature of Chrome OS, it is a basic feature to allow for a more smooth experience.  

Did this work before? No 

Chrome version: 70.0.3538.34  Channel: beta
OS Version: 11021.28.0
Flash Version: 31.0.0.118

Linux support is a huge advance to Chrome OS. But this limitation severely decreases the potential of Linux apps since the user is forced to manually sync files copying in and out the container.

Comment 1 by edurmac...@gmail.com, Oct 1 

Indirect Related Issue:  841787  - SUpport for FUSE on Linux

That would be a start, not for every user though.

Comment 2 by dtapu...@chromium.org, Oct 3

Components: OS>Systems>Containers

Comment 3 by tbuckley@google.com, Oct 8

Labels: Proj-Containers

Comment 4 by jkardatzke@chromium.org, Oct 17

Cc: tbuck...@chromium.org
Owner: joelhockey@chromium.org
Status: Assigned (was: Unconfirmed)
Based on the discussion in yesterday's meeting, assigning to Joel.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a5bd13ba277aa067ea323dc7ea5ad5d0d18dc4fd

commit a5bd13ba277aa067ea323dc7ea5ad5d0d18dc4fd
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Oct 23 20:01:45 2018

system_api: seneschal: New storage_locations in seneschal .proto

Added DRIVEFS_* and REMOVABLE storage location types.

BUG= chromium:878324 
BUG= chromium:890649 
TEST=Install on device, test sharing with FilesApp

Change-Id: I9fd0a4e4b3b5bbd5c299139071de4a7b4f35f094
Reviewed-on: https://chromium-review.googlesource.com/1287389
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/a5bd13ba277aa067ea323dc7ea5ad5d0d18dc4fd/system_api/dbus/seneschal/seneschal_service.proto
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac476a6ee4c10885bf21705a21705d8b05fc8d4a

commit ac476a6ee4c10885bf21705a21705d8b05fc8d4a
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Oct 24 10:26:22 2018

CrOS FilesApp: Share from DriveFS with crostini container.

Depends on
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1287389
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1287390

Bug:  878324 
Bug:  890649 
Change-Id: I20b57cc7900727fa15ef2de12d247052dd040bff
Reviewed-on: https://chromium-review.googlesource.com/c/1288095
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602288}
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/file_manager/path_util_unittest.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/test/data/extensions/api_test/file_browser/crostini_test/test.js
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chromeos/dbus/fake_seneschal_client.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chromeos/dbus/fake_seneschal_client.h
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/ui/file_manager/file_manager/foreground/js/crostini.js
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/ui/file_manager/file_manager/foreground/js/crostini_unittest.js
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/ui/file_manager/file_manager/test/crostini_share.js
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/ui/file_manager/file_manager/test/js/strings.js
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac476a6ee4c10885bf21705a21705d8b05fc8d4a

commit ac476a6ee4c10885bf21705a21705d8b05fc8d4a
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Oct 24 10:26:22 2018

CrOS FilesApp: Share from DriveFS with crostini container.

Depends on
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1287389
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1287390

Bug:  878324 
Bug:  890649 
Change-Id: I20b57cc7900727fa15ef2de12d247052dd040bff
Reviewed-on: https://chromium-review.googlesource.com/c/1288095
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602288}
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/browser/chromeos/file_manager/path_util_unittest.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chrome/test/data/extensions/api_test/file_browser/crostini_test/test.js
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chromeos/dbus/fake_seneschal_client.cc
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/chromeos/dbus/fake_seneschal_client.h
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/ui/file_manager/file_manager/foreground/js/crostini.js
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/ui/file_manager/file_manager/foreground/js/crostini_unittest.js
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/ui/file_manager/file_manager/test/crostini_share.js
[modify] https://crrev.com/ac476a6ee4c10885bf21705a21705d8b05fc8d4a/ui/file_manager/file_manager/test/js/strings.js

Comment 8 by joelhockey@chromium.org, Oct 24

Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9d0058fdd31507faae72dbf3ad1c42f9f39e717d

commit 9d0058fdd31507faae72dbf3ad1c42f9f39e717d
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Oct 24 20:03:13 2018

vm_tools: seneschal: Support sharing for drivefs

Updated seneschal.conf to mount /media in addition to /home.

Added MEDIA storage_location to support drivefs and removable media.

DriveFS allows paths at /media/fuse/drivefs-<drivefshash> and maps
paths into the container as:
<drivefs>/root/       => /ChromeOS/Google Drive/My Drive
<drivefs>/team_drives => /ChromeOS/Google Drive/Team Drives
<drivefs>/Computers   => /ChromeOS/Google Drive/Computers

Removable maps paths directly from /media/removable to
/ChromeOS/removable.

CQ-DEPEND=CL:1287389
BUG= chromium:878324 
BUG= chromium:890649 
TEST=Install on device, test sharing with FilesApp

Change-Id: I58445de317392e4b03b6e29fc502ca8c31f18b8b
Reviewed-on: https://chromium-review.googlesource.com/1287390
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/9d0058fdd31507faae72dbf3ad1c42f9f39e717d/vm_tools/seneschal/service.cc
[modify] https://crrev.com/9d0058fdd31507faae72dbf3ad1c42f9f39e717d/vm_tools/init/seneschal.conf
►

Sign in to add a comment