New issue
Advanced search Search tips

Issue 890632 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Last image on webpage is not inspectable

Reported by hakerh403@gmail.com, Sep 30

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3555.2 Safari/537.36

Steps to reproduce the problem:
1. Open the provided index.htm
2. Scroll to the bottom
3. Try to inspect the last image

What is the expected behavior?
Devtools should be opened and the image selected.

What went wrong?
The image is not selected.

Did this work before? N/A 

Chrome version: 67.0.3396.87  Channel: stable
OS Version: 6.3
Flash Version: /
 
index.htm
3.9 KB View Download
screencast.webm
1.3 MB View Download
Labels: Needs-Milestone
Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eda6f1d4f188141803cf61559826f9582d2b95b0

commit eda6f1d4f188141803cf61559826f9582d2b95b0
Author: Erik Luo <luoe@chromium.org>
Date: Mon Dec 03 20:43:29 2018

DevTools: revealing existing nodes should expand children limit

To reveal and select a node, we would call 'onpopulate' on all of its
ancestors without a TreeElement, which ensured that the node's own
TreeElement would be constructed.

When a parent has 500+ children, extra nodes are lazily built after
clicking a "Show more" button. To allow revealing hidden nodes,
this CL expands the limit if a parent is already populated.

Bug:  890632 
Change-Id: Ia7b916c21baf5b35dbce8a26eca1681c9bb0b243
Reviewed-on: https://chromium-review.googlesource.com/c/1320569
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613231}
[modify] https://crrev.com/eda6f1d4f188141803cf61559826f9582d2b95b0/third_party/blink/renderer/devtools/front_end/elements/ElementsTreeOutline.js
[add] https://crrev.com/eda6f1d4f188141803cf61559826f9582d2b95b0/third_party/blink/web_tests/http/tests/devtools/elements/inspect-limited-children-expected.txt
[add] https://crrev.com/eda6f1d4f188141803cf61559826f9582d2b95b0/third_party/blink/web_tests/http/tests/devtools/elements/inspect-limited-children.js

Status: Fixed (was: Assigned)
Thanks for the report, the repro html and screencast were useful.  A fix has landed and will reach Canary soon.

Sign in to add a comment