#video-rotate-to-fullscreen affecting videos with nofullscreen in controlsList
Reported by
terrenpr...@gmail.com,
Sep 30
|
||||||
Issue descriptionDevice name: OnePlus 3T From "Settings > About Chrome" Application version: 71.0.3565.0 Operating system: Android 8.0.0; ONEPLUS A3000 Build/OPR1.170623.032 Demo link: https://terpro.github.io/samples/fullscreentest.html Steps to reproduce: (1) Start playing video with fullscreen option disabled (nofullscreen in controlsList attribute) (2) Rotate device into landscape mode Expected result: Page should rotate, but grayed out fullscreen button suggests that video shouldn't enter fullscreen mode. Actual result: Video enters fullscreen mode
,
Oct 3
Tested the issue in Android and able to reproduce the issue. Steps Followed: 1. Navigated to https://terpro.github.io/samples/fullscreentest.html , played video 2. rotated device go landscape mode -- observed video in fullscreen mode Chrome versions tested: 69.0.3497.0 , 71.0.3568.0 OS: Android 9.0.0 Android Devices: Pixel 2 Using the per-revision bisect providing the bisect results, Last Bad Build - 65.0.3318.0 First Good Build - 65.0.3319.0 CL: https://chromium.googlesource.com/chromium/src/+/db76d1f9c486bc48c90ca07779b767b7870b92ed @ juncai: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to owner concerned. Thanks!
,
Oct 3
Media elements listed for device orientation events to decide whether or not to go full screen. If they are doing it when they aren't supposed to that's not a problem with the sensor API.
,
Oct 3
,
Oct 4
controlsList is only expected to grey out the entry in the controls. We could consider blocking auto-fullscreen when the option is set too. What's your use case?
,
Oct 4
I'm building a PWA with videos. I want to change the layout when the device is rotated, doesn't work very well when videos enter fullscreen. I disabled the fullscreen option, so I see no reason why rotation should cause it to enter fullscreen anyway.
,
Oct 4
Fair enough.
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6739e5e490b27be71e2c927f270e6f81a8e4af36 commit 6739e5e490b27be71e2c927f270e6f81a8e4af36 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Thu Oct 04 17:40:40 2018 Media Controls: do not rotate to fullscreen when controlsList=nofullscreen. Bug: 890602 Change-Id: I7c271882ec632670caf555316e53d9baeba45294 Reviewed-on: https://chromium-review.googlesource.com/c/1260513 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596739} [modify] https://crrev.com/6739e5e490b27be71e2c927f270e6f81a8e4af36/third_party/blink/renderer/modules/media_controls/media_controls_rotate_to_fullscreen_delegate.cc [modify] https://crrev.com/6739e5e490b27be71e2c927f270e6f81a8e4af36/third_party/blink/renderer/modules/media_controls/media_controls_rotate_to_fullscreen_delegate_test.cc
,
Oct 4
This will be fixed in Chrome 71. Thank you for filing the report! :) |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by chelamcherla@chromium.org
, Oct 1