New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 890597 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
OOO until 2019-01-24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 904045
issue 891026



Sign in to add a comment

Stack-overflow in blink::WebGLRenderingContextBase::GetImage

Project Member Reported by ClusterFuzz, Sep 30

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5645964621381632

Fuzzer: inferno_twister
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Stack-overflow
Crash Address: 0x7fff5cbe9fd8
Crash State:
  blink::WebGLRenderingContextBase::GetImage
  blink::WebGLRenderingContextBase::CopyRenderingResultsFromDrawingBuffer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=576151:576155

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5645964621381632

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 30

Components: Blink>WebGL
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Sep 30

Labels: Test-Predator-Auto-Owner
Owner: junov@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/00d64e2ea02ea16beb67f92ee971871402185eae (Make WebGL use CanvasResource for submitting to OffscreenCanvas.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Assigned)
Not immediately reproducible on macOS with 71.0.3556.0 (Official Build) canary (64-bit). Would presumably need an ASAN build to reproduce. I don't think this is a code path likely to be commonly hit so am downgrading this to P2.

Blockedon: 891026
Owner: kbr@chromium.org
Status: Assigned (was: Available)
Can't reproduce with a local build with the following GN args:

is_debug = false
use_goma = true
dcheck_always_on = true
ffmpeg_branding="Chrome"
proprietary_codecs=true
# ASAN build
is_component_build = false
is_asan=true
enable_nacl=false

but I realize now that I should have mimicked the GN args from the testcase.

enable_ipc_fuzzer = true
enable_nacl = false
ffmpeg_branding = "Chrome"
is_asan = true
is_component_build = false
is_debug = false
proprietary_codecs = true
sanitizer_coverage_flags = "trace-pc-guard"
strip_absolute_paths_from_debug_symbols = true
v8_enable_verify_heap = true

Rebuilding.

Cc: fs...@chromium.org
Rebuilding with those command-line arguments, the stack overflow still doesn't reproduce on my Mac laptop. I can however see the potential stack overflow contained in the Clusterfuzz report via code inspection:

    #13 0x126f43f34 in blink::WebGLRenderingContextBase::GetImage(blink::AccelerationHint) const third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc:803:8
     #14 0x126f445a4 in blink::WebGLRenderingContextBase::CopyRenderingResultsFromDrawingBuffer(blink::CanvasResourceProvider*, blink::SourceDrawingBuffer) const third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc:1615:44

Project Member

Comment 7 by ClusterFuzz, Oct 9

ClusterFuzz has detected this issue as fixed in range 597817:597820.

Detailed report: https://clusterfuzz.com/testcase?key=5645964621381632

Fuzzer: inferno_twister
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Stack-overflow
Crash Address: 0x7fff5cbe9fd8
Crash State:
  blink::WebGLRenderingContextBase::GetImage
  blink::WebGLRenderingContextBase::CopyRenderingResultsFromDrawingBuffer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=576151:576155
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=597817:597820

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5645964621381632

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Oct 9

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5645964621381632 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -ClusterFuzz-Verified ClusterFuzz-Wrong
Status: Assigned (was: Verified)
Pretty sure this verification was wrong. Initialized a redo.

[2018-10-09 17:45:09 UTC] kainino@google.com: Redo task(s): progression
[2018-10-09 17:45:41 UTC] vm29-m84.golo.chromium.org: Progression task started: r597942.
[2018-10-09 19:06:00 UTC] vm91-m84.golo.chromium.org: Progression task finished.

Fixed:	NO
Project Member

Comment 11 by ClusterFuzz, Oct 12

ClusterFuzz has detected this issue as fixed in range 598905:598908.

Detailed report: https://clusterfuzz.com/testcase?key=5645964621381632

Fuzzer: inferno_twister
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Stack-overflow
Crash Address: 0x7fff5cbe9fd8
Crash State:
  blink::WebGLRenderingContextBase::GetImage
  blink::WebGLRenderingContextBase::CopyRenderingResultsFromDrawingBuffer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=576151:576155
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=598905:598908

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5645964621381632

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Blockedon: 904045

Sign in to add a comment