Can't get "autoCapitalize" value from context |
|||||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: M70 M71 What steps will reproduce the problem? (1) Put focus into input box. (2) Check the value of context. What is the expected result? There are "autoCapitalize" property in context What happens instead? There are not "autoCapitalize" property in context The root cause is: There are two onFocus interfaces, one for public version, the other for private version. "autoCapitalize" already add to the public version, however, it's forgotten to add private version. private version:https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc?rcl=056317cf8b13149e5b83b1d7382c49d2ce0f8e7f&l=205 public version: https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/input_ime/input_ime_api.cc?type=cs&g=0&l=53
,
Sep 29
,
Sep 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/380ac66043a6c447d4b32d1a445a2ae19a912cbb commit 380ac66043a6c447d4b32d1a445a2ae19a912cbb Author: Shu Chen <shuchen@google.com> Date: Sat Sep 29 09:37:30 2018 Makes sure the inputMethodPrivate.onFocus() event can carry the auto capitalize property. Bug: 890561 Change-Id: Ie766224794a0b34a8f6f9d94894e9dfbe6db5f28 Reviewed-on: https://chromium-review.googlesource.com/1253262 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by: Lan Wei <azurewei@chromium.org> Cr-Commit-Position: refs/heads/master@{#595311} [modify] https://crrev.com/380ac66043a6c447d4b32d1a445a2ae19a912cbb/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc [modify] https://crrev.com/380ac66043a6c447d4b32d1a445a2ae19a912cbb/chrome/common/extensions/api/input_method_private.json
,
Sep 30
,
Sep 30
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2
,
Oct 2
Please mark which OS's this is impacting.
,
Oct 2
Done.
,
Oct 4
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b278c31e6980c2156077cf21c4c49628a0a81400 Commit: b278c31e6980c2156077cf21c4c49628a0a81400 Author: shuchen@google.com Commiter: shend@chromium.org Date: 2018-10-04 23:52:42 +0000 UTC [Merge M70] Makes sure the inputMethodPrivate.onFocus() event can carry the auto capitalize property. Bug: 890561 Change-Id: Ie766224794a0b34a8f6f9d94894e9dfbe6db5f28 Reviewed-on: https://chromium-review.googlesource.com/1253262 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by: Lan Wei <azurewei@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#595311}(cherry picked from commit 380ac66043a6c447d4b32d1a445a2ae19a912cbb) Reviewed-on: https://chromium-review.googlesource.com/c/1252223 Reviewed-by: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#866} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b278c31e6980c2156077cf21c4c49628a0a81400 commit b278c31e6980c2156077cf21c4c49628a0a81400 Author: Shu Chen <shuchen@google.com> Date: Thu Oct 04 23:52:42 2018 [Merge M70] Makes sure the inputMethodPrivate.onFocus() event can carry the auto capitalize property. Bug: 890561 Change-Id: Ie766224794a0b34a8f6f9d94894e9dfbe6db5f28 Reviewed-on: https://chromium-review.googlesource.com/1253262 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by: Lan Wei <azurewei@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#595311}(cherry picked from commit 380ac66043a6c447d4b32d1a445a2ae19a912cbb) Reviewed-on: https://chromium-review.googlesource.com/c/1252223 Reviewed-by: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#866} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/b278c31e6980c2156077cf21c4c49628a0a81400/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc [modify] https://crrev.com/b278c31e6980c2156077cf21c4c49628a0a81400/chrome/common/extensions/api/input_method_private.json |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 Deleted