New issue
Advanced search Search tips

Issue 890549 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

background-fixed images are not repainted after Inspect Element is docked to the bottom

Reported by chihuahu...@gmail.com, Sep 29

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36

Example URL:
https://jsfiddle.net/3suetm0f/embedded/result

Steps to reproduce the problem:
1. Visit any site that uses background-image and background-attachment: fixed;
2. Open Inspect Element
3. Dock it to the side
4. Dock it to the bottom
5. Close Inspect Element

Screenshot: https://i.imgur.com/DsmR0ST.jpg

Video: https://streamable.com/n4wfj

What is the expected behavior?
The background image should appear like it normally does.

What went wrong?
The part of the background image that was covered by Inspect Element will not be redrawn when Inspect Element is closed. The background color will be shown instead. 

Does it occur on multiple sites: Yes

Is it a problem with a plugin? N/A 

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 69.0.3497.100  Channel: stable
OS Version: 10.0
Flash Version: 

This issue has been around for ages; it's not a recent regression.

The bug doesn't appear when you open and close Inspect Element normally; it only happens when it begins docked to the side and is then moved to the bottom.

The same issue would probably occur when docking it to the side, but doing so causes the viewport to resize, which then repaints the background image anyway. So the bug probably goes unnoticed in that case.
 

Comment 1 Deleted

Components: -Blink Blink>Paint
Labels: Needs-Bisect Needs-Triage-M69
Cc: viswa.karala@chromium.org
Labels: -Needs-Bisect Triaged-ET Target-71 M-71 FoundIn-71 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on chrome reported version# 69.0.3497.100 and on latest chrome# 71.0.3566.0 on Ubuntu 14.04, Windows-10 and Mac 10.12.6 using the URL provided in comment# 0. As this issue is seen from M-60(60.0.3112.0), hence considering this issue as Non-Regression and marking it as Untriaged.

Thanks!
Labels: FoundIn-70 FoundIn-69
++ labels
Components: -Blink>Paint Blink>Paint>Invalidation Platform>DevTools
Status: Available (was: Untriaged)
How does DevTools notify the renderer that it has been removed?

Fascinating bug.
Owner: schenney@chromium.org
Status: Assigned (was: Available)
When devtools is removed, app layout changes which leads to the web content resize. We can see layout update, so something is fishy with paint / compositing. Bath to you.
Cc: wangxianzhu@chromium.org
Components: -Platform>DevTools
Owner: ----
Status: Available (was: Assigned)
Interesting that layout updates but not paint, so probably missing some invalidation for background images on the size change.
Cc: -wangxianzhu@chromium.org
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0567c6cb3ec150f8615e9b719217a9708d4fa1a1

commit 0567c6cb3ec150f8615e9b719217a9708d4fa1a1
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Jan 18 00:43:46 2019

[PE] Fix background-attachment:fixed invalidation in some cases

We should always invalidate background-attachment:fixed background when
the layout view's background rect changes. Previously we expected
incremental invalidation but that doesn't work for fixed attachment
backgrounds which depend on the viewport background size instead of
the size of the object's visual rect.

Bug:  890549 
Change-Id: I447956b4f8c06e9c94fa9352389979e8e6ced22d
Reviewed-on: https://chromium-review.googlesource.com/c/1418496
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623930}
[modify] https://crrev.com/0567c6cb3ec150f8615e9b719217a9708d4fa1a1/third_party/blink/renderer/core/paint/box_paint_invalidator.cc
[add] https://crrev.com/0567c6cb3ec150f8615e9b719217a9708d4fa1a1/third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/paint/invalidation/window-resize/window-resize-child-background-image-fixed-tiled-expected.txt
[add] https://crrev.com/0567c6cb3ec150f8615e9b719217a9708d4fa1a1/third_party/blink/web_tests/paint/invalidation/window-resize/window-resize-child-background-image-fixed-tiled-expected.html
[add] https://crrev.com/0567c6cb3ec150f8615e9b719217a9708d4fa1a1/third_party/blink/web_tests/paint/invalidation/window-resize/window-resize-child-background-image-fixed-tiled-expected.txt
[add] https://crrev.com/0567c6cb3ec150f8615e9b719217a9708d4fa1a1/third_party/blink/web_tests/paint/invalidation/window-resize/window-resize-child-background-image-fixed-tiled.html

Comment 11 by wangxianzhu@chromium.org, Jan 18 (5 days ago)

Status: Fixed (was: Assigned)

Sign in to add a comment