New issue
Advanced search Search tips

Issue 890545 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 906968



Sign in to add a comment

Silence repeated identical warnings on consecutive patchsets

Project Member Reported by liber...@chromium.org, Sep 29

Issue description

i often upload WIP CLs that are far from finished, just to see the code all in one place in a convenient way.

having (many) tricium comments in the middle of my WIP CLs makes them hard to read.  it's particularly low information since i don't make any attempt to spell check them at this point.  i even get TODO spelled wrong sometimes :)
 
Cc: mar...@chromium.org
Labels: -Pri-3 Pri-2
Summary: Silence false positives on repeated uploads (maybe limited to WIP) (was: Please don't run Tricium on WIP CLs)
Thanks for the report; I can see how comments may get in the way, especially if there are many noisy comments.

As far as I understand, the comments are annoying in the case where there are:
 1. repeated uploads
 2. false positives

Maybe a better behavior would be to inhibit repeated comments, so comments already reported in previous patchsets are not re-sent. This might also be reasonable behavior for non-WIP CLs. What do you think?

I'd be hesitant to just stop running on WIP CLs, because in many cases, it may be useful to get the comments in a WIP patch so that you can fix nits before sending for review.
Could tricium scan the commit header for some special text, like "notricium: true", similar to nopresumbit or notry?  then, by default, one would get tricium comments on WIP CLs, but one could turn it off manually for my (probably less common) use-case until i'm ready to clean it up for review.

Repeated comments are probably safe to prune for non-WIP too.  I'd expect most folks are good about not tracking comments across PSs, since it's fairly common to have human-provided comments on different PSs too.

thanks!
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
Summary: Silence repeated identical warnings on consecutive patchsets (was: Silence false positives on repeated uploads (maybe limited to WIP))
Sounds like a good idea, I think it would make sense to have a commit description flag like that. Filed bug 891090.

I'll make this bug focused on avoiding posting the same message repeatedly on each patchset.
This feedback was also brought up by foolip@ in  bug 893108 :

> Having the same typo reported over and over was too much.
> Like other review comments, perhaps the same issue, if it still applies, could simply be left as the original comment, unresolved, or at most adding a comment there saying "problem still applies".
Blocking: 906968
To me it would be the most useful to have a "Mute" button or to have the "Not useful" button no longer send the same warnings on consecutive patchset.

Adding a special text is probably an appropriate workaround for when you do not want to get tricium comments at all (see my comment about this here: https://bugs.chromium.org/p/chromium/issues/detail?id=891090#c7).

But for cases when you do want tricium comments and consider some of the comments not useful, having a way to mute them would be ideal.

Sign in to add a comment