New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 890524 link

Starred by 2 users
Status: Assigned
Owner:
tbroch@chromium.org
Cc:
█ scollyer@chromium.org
█ marc...@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Eve] doesn't restore power for usb type-c hub after resume

Project Member Reported by tutankhamen@chromium.org, Sep 29 
Chrome Version: eve-release/R71-11077.0.0

What steps will reproduce the problem?
(1) Connect Havit USB type C -> HDMI/USB dongle to port A (or any other USB type C -> HDMI/USB adapter)
(2) Connect Apple USB type C -> HDMI/USB dongle to port B
(3) Send Eve to suspend mode
(4) Resume it

What is the expected result?
Eve should restore power for both adapters

What happens instead?
Eve restores power only for Apple adapter

[b]Details:[/b]

Both adapters are connected to 1080p monitors using HDMI cables. No power cable was connected neither to chromebook nor adapters. [modetest] shows that both connectors are disconnected after resume. 

------------------
- Before suspend -
------------------

modetest:

57      56      connected       eDP-1           260x170         1       56
65      64      connected       DP-1            520x320         27      64
71      70      connected       DP-2            510x290         35      70

ectool gpioget:

1 USB_C0_PD_INT_ODL                0x0210
1 USB_C1_PD_INT_ODL                0x0210
1 USB_C0_CABLE_DET                 0x0110
1 USB_C1_CABLE_DET                 0x0110
1 USB_C0_5V_EN                     0x0062
1 USB_C1_5V_EN                     0x0062
0 EN_USB_C0_3A                     0x0060
0 EN_USB_C1_3A                     0x0060
1 USB_C0_PD_RST_L                  0x0060
1 USB_C1_PD_RST_L                  0x0060
1 USB_C0_DP_HPD                    0x0010
1 USB_C1_DP_HPD                    0x0010
1 USB_C0_TCPC_PWR                  0x0060
1 USB_C1_TCPC_PWR                  0x0060

ectool usbdpmuxinfo:

Port 0: USB DP INV
Port 1: USB DP INV


ectool usbpdpower:

Port 0: SRC 1500mA             
Port 1: SRC 1500mA             

----------------
- After resume -
----------------

modetest:

57      56      connected       eDP-1           260x170         1       56
65      0       disconnected    DP-1            520x320         0       64
71      0       disconnected    DP-2            510x290         0       70

ectool gpioget:

1 USB_C0_PD_INT_ODL                0x0210
1 USB_C1_PD_INT_ODL                0x0210
1 USB_C0_CABLE_DET                 0x0110
1 USB_C1_CABLE_DET                 0x0110
0 USB_C0_5V_EN                     0x0062
1 USB_C1_5V_EN                     0x0062
0 EN_USB_C0_3A                     0x0060
1 EN_USB_C1_3A                     0x0060
1 USB_C0_PD_RST_L                  0x0060
1 USB_C1_PD_RST_L                  0x0060
0 USB_C0_DP_HPD                    0x0010
1 USB_C1_DP_HPD                    0x0010
1 USB_C0_TCPC_PWR                  0x0060
1 USB_C1_TCPC_PWR                  0x0060


ectool usbpdmuxinfo:

Port 0: USB INV                  
Port 1: USB DP INV               


ectool usbpdpower:

Port 0: SRC 1500mA             
Port 1: SRC 3000mA             

ectool console:
--new
[3008.195405 DPTF sensor 4, threshold 120 C, index 0, enabled]
[3008.200346 DPTF sensor 4, threshold 75 C, index 1, enabled] 
[3008.206069 DPTF sensor 4, threshold 120 C, index 0, enabled] 
[3008.209349 DPTF sensor 4, threshold 65 C, index 1, enabled]  
[3008.216092 DPTF sensor 3, threshold 120 C, index 0, enabled] 
[3008.218148 DPTF sensor 3, threshold 75 C, index 1, enabled]  
[3008.222065 DPTF sensor 3, threshold 120 C, index 0, enabled] 
[3008.224370 DPTF sensor 3, threshold 65 C, index 1, enabled]  
[3008.229581 DPTF sensor 2, threshold 120 C, index 0, enabled] 
[3008.232132 DPTF sensor 2, threshold 75 C, index 1, enabled]  
[3008.236422 DPTF sensor 2, threshold 120 C, index 0, enabled] 
[3008.238960 DPTF sensor 2, threshold 55 C, index 1, enabled]  
[3008.243399 DPTF sensor 1, threshold 120 C, index 0, enabled] 
[3008.245961 DPTF sensor 1, threshold 70 C, index 1, enabled]  
[3008.248944 DPTF sensor 1, threshold 120 C, index 0, enabled] 
[3008.252103 DPTF sensor 1, threshold 55 C, index 1, enabled]  




Power tester: https://www.amazon.com/Satechi-Tester-Multimeter-MacBook-Samsung/dp/B01MT8MC3N
Havit adapter: https://www.prohavit.com/products/hv-tpc68-usb-c-hub/
Apple adapter: https://www.apple.com/shop/product/MJ1K2AM/A/usb-c-digital-av-multiport-adapter

Comment 1 Deleted

Comment 2 Deleted

Comment 3 Deleted

Comment 4 by tbroch@chromium.org, Oct 1

Cc: scollyer@chromium.org
Components: OS>Firmware>EC
Status: Assigned (was: Untriaged)
Thanks for filing. What's  notable for me is that the C1 ports 3A gpio asserts and more importantly the C0 ports 5V power is disabled.  This leads to no power to the 'havit' adapter.

1 EN_USB_C1_3A                     0x0060
0 USB_C0_5V_EN                     0x0062

Can you also attach output of 

ectool usbpdmuxinfo
ectool usbpdpower
ectool console

Looks like settings for those GPIOs are governed in ec/board/eve/usb_pd_policy.c here:

static void board_vbus_update_source_current(int port)

I'll look to mod the EC to provide some more visibility into how its making the choice to flip those GPIOs

Comment 5 by tutankhamen@chromium.org, Oct 1

Description: Show this description

Comment 6 by tutankhamen@chromium.org, Oct 2 

added.

Comment 7 by tbroch@chromium.org, Oct 3 

@#6, not seeing any attachments

Comment 8 by tutankhamen@chromium.org, Oct 4 

I've added it to the original message.

Comment 9 by tbroch@chromium.org, Oct 5 

Thanks ... apolgies I missed.  Didn't realize you could revise description field.

So there's definitely a disconnect between usbpdpower which is showing 

Port 0: SRC 1500mA             

while,
0 USB_C0_5V_EN                     0x0062

Will attach an eve ec.bin w/ some visibility into the gpio-setting.  For example here's the output of 'ectool console'

C0 st14
C0 st15
vbus C0: 3A:1 5V:0
vbus C1: 3A:0 5V:0
vbus C0: 3A:1 5V:1  
C0 st17
C0 st18
vbus C0: 3A:0 5V:1
vbus C1: 3A:0 5V:0
vbus C1: 3A:0 5V:1

CL is here: crrev.com/c/1265421

Mind trying to the ec.bin on your setup and posting output?

Comment 10 by tbroch@chromium.org, Oct 5

ec.bin
512 KB Download

Comment 11 by tutankhamen@google.com, Oct 17 

Sorry, I'm on vacation - will try when I come back.

Comment 12 by tbroch@google.com, Nov 20

Summary: [Eve] doesn't restore power for usb type-c hub after resume (was: [Eve] Eve doesn't restore power for usb type-c hub)
Any chance to test ec binary in #10?
►

Sign in to add a comment