New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 890521 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

Fill in placeholder in new 'Chromebook added' notification header string with host name

Project Member Reported by jordynass@chromium.org, Sep 28

Issue description

I added the string with a placeholder and put off filling it in because of string freeze. It will appear with '$1' in the user facing text until this is fixed.

khorimoto@ did an almost identical task in https://chromium-review.googlesource.com/c/chromium/src/+/1194295
 
Cc: jessejames@chromium.org jlklein@chromium.org lesliewatkins@chromium.org jordynass@chromium.org khorimoto@chromium.org nohle@chromium.org jhawkins@chromium.org hansberry@chromium.org
Owner: jordynass@chromium.org
Status: Started (was: Available)
Cc: shibasheikh@chromium.org jon...@chromium.org
 Issue 890425  has been merged into this issue.
 Issue 891492  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8529ce8d191c74230b4bb2c51c850be035a0b55

commit c8529ce8d191c74230b4bb2c51c850be035a0b55
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Wed Oct 03 00:07:39 2018

[CrOS MultiDevice] Provide host name to 'Chromebook added' notification

The new strings for settings (added in
https://chromium-review.googlesource.com/c/chromium/src/+/1252915)
include a notification title that contains the host device name. This
CL provides it as an argument to
MultiDeviceNotificationPresenter::OnNewChromebookAddedForExistingUser
and updates the references to that function. Several of these are for
tests (unit and manual).

Screenshot of the new notification: http://screen/fzqJUOtSgHV

Bug:  890521 
Change-Id: If3586ea526866530a35b35d80957c57d3c83fe5c
Reviewed-on: https://chromium-review.googlesource.com/c/1252338
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596058}
[modify] https://crrev.com/c8529ce8d191c74230b4bb2c51c850be035a0b55/ash/multi_device_setup/multi_device_notification_presenter.cc
[modify] https://crrev.com/c8529ce8d191c74230b4bb2c51c850be035a0b55/ash/multi_device_setup/multi_device_notification_presenter.h
[modify] https://crrev.com/c8529ce8d191c74230b4bb2c51c850be035a0b55/ash/multi_device_setup/multi_device_notification_presenter_unittest.cc
[modify] https://crrev.com/c8529ce8d191c74230b4bb2c51c850be035a0b55/chromeos/services/multidevice_setup/account_status_change_delegate_notifier_impl.cc
[modify] https://crrev.com/c8529ce8d191c74230b4bb2c51c850be035a0b55/chromeos/services/multidevice_setup/account_status_change_delegate_notifier_impl.h
[modify] https://crrev.com/c8529ce8d191c74230b4bb2c51c850be035a0b55/chromeos/services/multidevice_setup/fake_account_status_change_delegate.cc
[modify] https://crrev.com/c8529ce8d191c74230b4bb2c51c850be035a0b55/chromeos/services/multidevice_setup/fake_account_status_change_delegate.h
[modify] https://crrev.com/c8529ce8d191c74230b4bb2c51c850be035a0b55/chromeos/services/multidevice_setup/multidevice_setup_impl.cc
[modify] https://crrev.com/c8529ce8d191c74230b4bb2c51c850be035a0b55/chromeos/services/multidevice_setup/public/mojom/multidevice_setup.mojom

Status: Fixed (was: Started)

Sign in to add a comment