New issue
Advanced search Search tips

Issue 890512 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 878028



Sign in to add a comment

Loading multiple skottie animation files should be cached

Project Member Reported by malaykeshav@chromium.org, Sep 28

Issue description

Right now each skia vector animation is a new instance even if some of them share the same resource file. This can be avoided by caching the common resource file and sharing it in the SkiaVectorAnimation object. 
 
Blockedon: -878028
Blocking: 878028
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f45bb828a740421d700c398ef3e7e0e8e39dd9ba

commit f45bb828a740421d700c398ef3e7e0e8e39dd9ba
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Wed Oct 03 04:06:58 2018

Implement a thread safe wrapper for Skottie

This patch implements a thread safe wrapper for the core skottie
animation object. We want to share the same animation resource file for
multiple SkiaVectorAnimation objects. This would allow us to do that.

This is also needed to implement the Phase 2 and Phase 3 of
rasterization where the rasterization would be handled by different
threads.

go/cros-skottie

Bug:  890512 ,  890224 
Change-Id: I40371e58985ea4db5661f28a2ee8b31aab354a03
Component: Skia vector animation, skottie
Reviewed-on: https://chromium-review.googlesource.com/c/1253071
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596118}
[modify] https://crrev.com/f45bb828a740421d700c398ef3e7e0e8e39dd9ba/ui/gfx/BUILD.gn
[modify] https://crrev.com/f45bb828a740421d700c398ef3e7e0e8e39dd9ba/ui/gfx/skia_vector_animation.cc
[modify] https://crrev.com/f45bb828a740421d700c398ef3e7e0e8e39dd9ba/ui/gfx/skia_vector_animation.h
[modify] https://crrev.com/f45bb828a740421d700c398ef3e7e0e8e39dd9ba/ui/gfx/skia_vector_animation_unittest.cc
[add] https://crrev.com/f45bb828a740421d700c398ef3e7e0e8e39dd9ba/ui/gfx/skottie_wrapper.cc
[add] https://crrev.com/f45bb828a740421d700c398ef3e7e0e8e39dd9ba/ui/gfx/skottie_wrapper.h

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d39d8b9535811da730e95969d0c191ca8cd7559

commit 9d39d8b9535811da730e95969d0c191ca8cd7559
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Sat Oct 20 01:52:17 2018

Cache and load skia animations via resource bundle

This patch implements the ability to load skia vector animation files
via the resource bundle. Each file is only loaded once and cached for
future use. ResourceBundle expects the animation file to be gzipped.

UMA metrics are also recorded to note the time to uncompress and parse
each animation file.

Bug:  890512 
Change-Id: Ie0e17dbee9198b12a886f3739a034ad366bf9478
Component: ResourceBundle, skia vector animations
Reviewed-on: https://chromium-review.googlesource.com/c/1272800
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601385}
[modify] https://crrev.com/9d39d8b9535811da730e95969d0c191ca8cd7559/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/9d39d8b9535811da730e95969d0c191ca8cd7559/ui/aura_extra/BUILD.gn
[modify] https://crrev.com/9d39d8b9535811da730e95969d0c191ca8cd7559/ui/aura_extra/DEPS
[add] https://crrev.com/9d39d8b9535811da730e95969d0c191ca8cd7559/ui/aura_extra/skia_vector_resource.cc
[add] https://crrev.com/9d39d8b9535811da730e95969d0c191ca8cd7559/ui/aura_extra/skia_vector_resource.h

Status: Fixed (was: Assigned)

Sign in to add a comment