Don't map localhost to penguin.linux.test for supported ports |
|||
Issue descriptionSince we now support localhost for certain ports (even when serving on 127.0.0.1 within the container), we should no longer map "localhost" to "penguin.linux.test" in these cases. See also: https://productforums.google.com/forum/#!topic/pixelbook/KAmz_oYbRlo;context-place=forum/pixelbook
,
Sep 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/765e9661fcc59ae1ea6f6ce8dfa10c7d141d43eb commit 765e9661fcc59ae1ea6f6ce8dfa10c7d141d43eb Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Sat Sep 29 07:27:36 2018 vm_tools: cicerone: Don't replace mapped ports in URL requests If we attempt to open a URL in the container that points to localhost or loopback, then we were replacing that with the container IP or penguin.linux.test. If we are the default container, and the port for that URL request is part of our existing mappings, then do not replace the hostname since localhost or loopback will work in that scenario. BUG= chromium:890506 TEST=xdg-open http://localhost:[8000|8001|8000/|8001/] work properly Change-Id: Iea4a04453600ee4e9931ff5a71fbda0bae5eb60c Reviewed-on: https://chromium-review.googlesource.com/1252331 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/765e9661fcc59ae1ea6f6ce8dfa10c7d141d43eb/vm_tools/cicerone/service.cc
,
Oct 1
,
Oct 8
Verified by running xdg-open http://localhost:[8000|8001|8000/|8001/] on 11137.0.0, 71.0.3567.0 on eve device. |
|||
►
Sign in to add a comment |
|||
Comment 1 by jkardatzke@chromium.org
, Sep 28