New issue
Advanced search Search tips

Issue 890498 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Tricium is much slower than expected for a change in chromium/src

Project Member Reported by qyears...@chromium.org, Sep 28

Issue description

When testing the newly-enabled Pylint analyzer in chromium/src, it took a full 10 minutes between uploading a new patchset and getting comments posted: See https://chromium-review.googlesource.com/c/chromium/src/+/1252845/2

First thing to check is where the latency is.

A few timing notes (all times PDT timezone):
 - patch upload at 2:48 PM
 - GitFileIsolator started at 2:51:27 PM
 - GitFileIsolator completed at 2:52:44 PM
 - Pylint started at 2:56:21 PM
 - Pylint completed at 2:56:29 PM
 - Comments posted at 2:58 PM

So it seems like it was slow to start both GitFileIsolator and Pylint; and it also took at least a minute to post after task completion

One little detail that seems important is this from the cloud tasks: the current rate is set to 1/s, for all task queues, whereas the actual rate of analyzers to run is probably more than 1/s:

  Queue Name	Tasks	Completed In Last Min.	Oldest Task ETA 	Maximum Rate
  driver-queue	141	60	2018-09-28 (15:10:28) 
(2 min 22 sec ago)	1/s

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/54775f842af31dcc21266ec49a62198eb5f1347a

commit 54775f842af31dcc21266ec49a62198eb5f1347a
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Mon Oct 01 21:54:05 2018

[tricium] Increase the driver task queue rate

This rate seems to be limiting the speed of Tricium jobs (probably).

Bug:  890498 
Change-Id: I21814e8612c4a5dc57b59c5cdc3574459ea786ae
Reviewed-on: https://chromium-review.googlesource.com/c/1252735
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17979}
[modify] https://crrev.com/54775f842af31dcc21266ec49a62198eb5f1347a/go/src/infra/tricium/appengine/frontend/queue.yaml

Status: Fixed (was: Assigned)
After deploying that change, it took 3 minutes to get comments instead of 10 minutes: https://chromium-review.googlesource.com/c/chromium/src/+/1252845/2 -- GitFileIsolator took almost two minutes of that (https://chromium-swarm.appspot.com/task?id=4053aef92f3df110&refresh=10&show_raw=1).

Sign in to add a comment