New issue
Advanced search Search tips

Issue 890455 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Fullscreen control host] Cleanup fullscreen control host logic for cocoa toolkit

Project Member Reported by yuweih@chromium.org, Sep 28

Issue description

We have now launched the MacViews. This bug tracks work to cleanup code that integrates fullscreen control host into the cocoa toolkit.
 
Cc: thakis@chromium.org yuweih@chromium.org weili@chromium.org
 Issue 892838  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9532a49ac15435e473ad4c3b08627ae5afd7faed

commit 9532a49ac15435e473ad4c3b08627ae5afd7faed
Author: Wei Li <weili@chromium.org>
Date: Mon Oct 08 17:38:56 2018

Remove the usage of ShouldHideUIForFullscreen() in tests

This is to prepare for removing ShouldHideUIForFullscreen() and the
entire Cocoa integration of FullscreenControlHost.

BUG= 890455 

Change-Id: If743e9c4d51312222d3dce1406040f5ad3b1e4f7
Reviewed-on: https://chromium-review.googlesource.com/c/1266118
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597599}
[modify] https://crrev.com/9532a49ac15435e473ad4c3b08627ae5afd7faed/chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b64dd4448aaf5c2889cfb7599fc9105ce950207e

commit b64dd4448aaf5c2889cfb7599fc9105ce950207e
Author: Yuwei Huang <yuweih@chromium.org>
Date: Sat Oct 13 00:25:05 2018

[Fullscreen Control Host] Post-MacViews cleanups for FullscreenControlHost

This CL cleans up logic that integrated FullscreenControlHost into the
Cocoa toolkit, since we have already launch MacViews:

* Simply pass BrowserView into FullscreenControlHost rather than passing
  the interfaces.
* Remove GetExclusiveAccessBubble() from ExclusiveAccessContext since it
  is no longer used.

Bug:  890455 
Change-Id: I318584a6747d7e3d1d1aa6d4a323bac01e9e3aad
Reviewed-on: https://chromium-review.googlesource.com/c/1252860
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599439}
[modify] https://crrev.com/b64dd4448aaf5c2889cfb7599fc9105ce950207e/chrome/browser/ui/browser_command_controller_unittest.cc
[modify] https://crrev.com/b64dd4448aaf5c2889cfb7599fc9105ce950207e/chrome/browser/ui/exclusive_access/exclusive_access_context.h
[modify] https://crrev.com/b64dd4448aaf5c2889cfb7599fc9105ce950207e/chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc
[modify] https://crrev.com/b64dd4448aaf5c2889cfb7599fc9105ce950207e/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/b64dd4448aaf5c2889cfb7599fc9105ce950207e/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.h
[modify] https://crrev.com/b64dd4448aaf5c2889cfb7599fc9105ce950207e/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/b64dd4448aaf5c2889cfb7599fc9105ce950207e/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/b64dd4448aaf5c2889cfb7599fc9105ce950207e/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc
[modify] https://crrev.com/b64dd4448aaf5c2889cfb7599fc9105ce950207e/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.h
[modify] https://crrev.com/b64dd4448aaf5c2889cfb7599fc9105ce950207e/chrome/browser/ui/views/media_router/presentation_receiver_window_view.cc
[modify] https://crrev.com/b64dd4448aaf5c2889cfb7599fc9105ce950207e/chrome/browser/ui/views/media_router/presentation_receiver_window_view.h

Status: Fixed (was: Assigned)

Sign in to add a comment