New issue
Advanced search Search tips

Issue 890452 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 862185
issue 688465
issue 841628



Sign in to add a comment

Make instrumentation tests a single apk

Project Member Reported by estevenson@chromium.org, Sep 28

Issue description

Some related issues:
  *  issue 841628 : Combine chrome_public_test_apk with chrome_public_for_test_apk
  *  issue 833545 : Get rid of chrome_sync_shell
  * issue 688465: Stop -keeping all Java native methods (weird proguard apk/apk_under_test interaction)

Idea here is that we'll still have the apk_under_test variable exposed to the instrumentation_test_apk template but then we'll use parts of the apk_under_test to build the final apk.

The test_runner should be a little simpler after this.

Any reason to not do this?
 
Description: Show this description
Also - this will speed up builds by not having the wait for the under_test proguard to finish before starting the test apk's proguard run. More context here:
https://bugs.chromium.org/p/chromium/issues/detail?id=848494#c9
I see no reason not to do this; the only reason I haven't done so already is time :(
Status: Assigned (was: Untriaged)
Will take a look this week
Blocking: 862185
Labels: QuickFix

Sign in to add a comment