Fix OWNERS file generation for libFuzzer targets on Windows |
|||
Issue descriptionThe recent fix to OWNERS file generation for libFuzzer targets caused it to break on Windows. This prevents building libFuzzer targets on Windows.
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c4cccbeb3a8177b4d7d994d67f7d1e434f98258 commit 1c4cccbeb3a8177b4d7d994d67f7d1e434f98258 Author: Jonathan Metzman <metzman@chromium.org> Date: Fri Sep 28 21:42:44 2018 [libFuzzer][Windows]Fix build breakage caused by OWNERS file generation. OWNERS file generation was broken for a long time until today. The fix caused the generation script to invoke the "git" command which breaks on Windows because "git" is not a binary on the path. This fix makes the script find the path of the git binary on Windows. Bug: 890451 Change-Id: Ib3df557170ac53ad259663dfec6bc5481b76f6d0 Reviewed-on: https://chromium-review.googlesource.com/1252464 Reviewed-by: Jonathan Metzman <metzman@chromium.org> Reviewed-by: Abhishek Arya <inferno@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595222} [modify] https://crrev.com/1c4cccbeb3a8177b4d7d994d67f7d1e434f98258/testing/libfuzzer/gen_fuzzer_owners.py
,
Oct 3
,
Oct 3
|
|||
►
Sign in to add a comment |
|||
Comment 1 by metzman@chromium.org
, Sep 28Labels: -Pri-3 Pri-1