New issue
Advanced search Search tips

Issue 890451 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 888363
issue 883538



Sign in to add a comment

Fix OWNERS file generation for libFuzzer targets on Windows

Project Member Reported by metzman@chromium.org, Sep 28

Issue description

The recent fix to OWNERS file generation for libFuzzer targets caused it to break on Windows. This prevents building libFuzzer targets on Windows.

 
Blocking: 883538 888363
Labels: -Pri-3 Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c4cccbeb3a8177b4d7d994d67f7d1e434f98258

commit 1c4cccbeb3a8177b4d7d994d67f7d1e434f98258
Author: Jonathan Metzman <metzman@chromium.org>
Date: Fri Sep 28 21:42:44 2018

[libFuzzer][Windows]Fix build breakage caused by OWNERS file generation.

OWNERS file generation was broken for a long time until today. The fix
caused the generation script to invoke the "git" command which breaks
on Windows because "git" is not a binary on the path.
This fix makes the script find the path of the git binary on Windows.

Bug:  890451 
Change-Id: Ib3df557170ac53ad259663dfec6bc5481b76f6d0
Reviewed-on: https://chromium-review.googlesource.com/1252464
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595222}
[modify] https://crrev.com/1c4cccbeb3a8177b4d7d994d67f7d1e434f98258/testing/libfuzzer/gen_fuzzer_owners.py

Status: Verified (was: Started)
Labels: OS-Windows

Sign in to add a comment