[jumbo] Build error in third_party/blink/renderer/core/svg/svg/svg_jumbo_2.o |
|||||
Issue descriptionI got this build error on my fedora box. Revision: r595094 (...) In file included from gen/third_party/blink/renderer/core/svg/svg_jumbo_2.cc:42: In file included from ./../../../third_party/blink/renderer/core/svg/svg_foreign_object_element.cc:25: In file included from ../../../third_party/blink/renderer/core/layout/svg/layout_svg_foreign_object.h:24: In file included from ../../../third_party/blink/renderer/core/layout/svg/layout_svg_block.h:23: In file included from ../../../third_party/blink/renderer/core/layout/layout_block_flow.h:44: In file included from ../../../third_party/blink/renderer/core/layout/layout_block.h:29: In file included from ../../../third_party/blink/renderer/core/layout/layout_box.h:30: In file included from ../../../third_party/blink/renderer/core/layout/custom/custom_layout_child.h:8: In file included from ../../../third_party/blink/renderer/core/css/cssom/prepopulated_computed_style_property_map.h:9: ../../../third_party/blink/renderer/core/css/css_property_id_templates.h:18:8: error: explicit specialization of 'WTF::HashTraits<blink::CSSPropertyID>' after instantiation struct HashTraits<blink::CSSPropertyID> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../../third_party/blink/renderer/platform/wtf/hash_map.h:71:20: note: implicit instantiation first required here typedef typename MappedTraits::TraitType MappedType; ^ 1 error generated. [32/376] CXX obj/third_party/blink/renderer/modules/indexeddb/indexeddb/indexeddb_jumbo_1.o ninja: build stopped: subcommand failed. GN args: is_debug = false dcheck_always_on = true use_ozone = true ozone_platform_wayland = true
,
Sep 28
,
Sep 28
Missing a forward/header declaration of a template specialization. C++ doesn't allow code to first instantiate a template (even if it's just an unresolved linker reference) and then define a specialization. Is that enough information to solve it? https://chromium-review.googlesource.com/c/chromium/src/+/1245785 is a similar fix but it's hidden behind a macro.
,
Sep 28
,
Sep 28
Probably missing include of third_party/blink/renderer/core/css/css_property_id_templates.h in the right place - svg_element.cc probably?
,
Oct 1
I uploaded https://chromium-review.googlesource.com/c/chromium/src/+/1253662 - which I hope should help - feel free to verify.
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c71bf5392cadb878c1e5e1f764f55d05b8e5fd1a commit c71bf5392cadb878c1e5e1f764f55d05b8e5fd1a Author: Fredrik Söderquist <fs@opera.com> Date: Mon Oct 01 09:47:01 2018 Include CSSPropertyID HashTraits in renderer/core/svg/svg_element.cc SVGElement::CssPropertyIdForSVGAttributeName has a: HashMap<StringImpl*, CSSPropertyID> which will require traits for the value (CSSPropertyID). Without Jumbo this usually works out by using the default traits. Bug: 890434 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6ff50a0648106057dad898d1fe6d79e9a53a1bd2 Reviewed-on: https://chromium-review.googlesource.com/1253662 Reviewed-by: Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#595414} [modify] https://crrev.com/c71bf5392cadb878c1e5e1f764f55d05b8e5fd1a/third_party/blink/renderer/core/svg/svg_element.cc
,
Oct 1
Thank you, bratell@ and fs@. It builds ok now.
,
Oct 5
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by toniki...@chromium.org
, Sep 28