New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 890425 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 890521
Owner:
Last visit > 30 days ago
Closed: Sep 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

Update Setup/Settings with unbranded strings

Project Member Reported by jlklein@chromium.org, Sep 28

Issue description

We need to replace the strings with updated unbranded equivalents at go/better-together-strings. 
 
Labels: -Pri-1 -Type-Bug Pri-0 Type-Feature
Status: Assigned (was: Untriaged)
Upping this to P0 since string freeze is today.
Cc: -jessejames@google.com jessejames@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98207b1741114f471968e110e4a5b26d044439bd

commit 98207b1741114f471968e110e4a5b26d044439bd
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Sat Sep 29 00:04:54 2018

[CrOS MultiDevice] Update notification/setup flow strings


Bug:  890425 
Change-Id: Id1150f263c6cd1fded5422b395ac94f0166687e2
Reviewed-on: https://chromium-review.googlesource.com/1252915
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595261}
[modify] https://crrev.com/98207b1741114f471968e110e4a5b26d044439bd/ash/ash_strings.grd
[modify] https://crrev.com/98207b1741114f471968e110e4a5b26d044439bd/chrome/app/chromeos_strings.grdp

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 29

Labels: -Pri-0 Pri-1
Mergedinto: 890521
Status: Duplicate (was: Started)
The remainder of the string update is to fix the placeholder in the notification title for the 'Chromebook added' notification. In particular, it is not due by string freeze so this is no longer P0.

Because the remainder is covered by the P1 https://bugs.chromium.org/p/chromium/issues/detail?id=890521, I'm marking it a dupblicate and demoting it to a P1.

Sign in to add a comment