New issue
Advanced search Search tips

Issue 890401 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 819761



Sign in to add a comment

Remove streamsPrivate extensions API

Project Member Reported by jam@chromium.org, Sep 28

Issue description

This was used the QuickOffice extension, but it was stopped using it in  bug 819761 .

Assigning to Devlin who said he'd be happy to remove it.
 
Cc: sa...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4750dc8238e821b924eb17470d0714a553dd007b

commit 4750dc8238e821b924eb17470d0714a553dd007b
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue Oct 09 17:23:59 2018

[Extensions] Remove streamsPrivate API

Remove the streamsPrivate API. It used to be needed by both the PDF
Reader extension and QuickOffice, but both have since migrated to the
MimeTypesHandler API.

Remove the API schema and function implementations, as well as the
feature declarations. Deprecate the old enum values used for the
API calls and permissions.

We need to leave in a portion of the StreamsPrivateAPI implementation
(specifically, StreamsPrivateAPI::SendExecuteMimeTypeHandlerEvent())
because it is also used in the MimeTypesHandler API. I've added a TODO
to move it to a new location, since streamsPrivate no longer makes
sense for it.

Bug: 890401

Change-Id: Idfb0d2504efc5f0a3ad269ae59d836d8e1d598ca
Reviewed-on: https://chromium-review.googlesource.com/c/1252322
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Zachary Kuznia <zork@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597972}
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/chrome/browser/extensions/api/streams_private/streams_private_api.cc
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/chrome/browser/extensions/api/streams_private/streams_private_api.h
[delete] https://crrev.com/153df6b0dc8843062add4bec9b44b4bc58e16df1/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/chrome/browser/plugins/plugin_response_interceptor_url_loader_throttle.cc
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/chrome/common/extensions/api/_permission_features.json
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/chrome/common/extensions/api/api_sources.gni
[delete] https://crrev.com/153df6b0dc8843062add4bec9b44b4bc58e16df1/chrome/common/extensions/api/streams_private.idl
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/chrome/common/extensions/permissions/chrome_api_permissions.cc
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/chrome/common/extensions/permissions/permission_set_unittest.cc
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/chrome/test/BUILD.gn
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/extensions/browser/extension_event_histogram_value.h
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/extensions/common/manifest_handlers/mime_types_handler.h
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/extensions/common/permissions/api_permission.h
[modify] https://crrev.com/4750dc8238e821b924eb17470d0714a553dd007b/tools/metrics/histograms/enums.xml

Sign in to add a comment