Download home v2: Thumbnail size scale to 0. |
||||
Issue descriptionChrome Version: 71.* OS: Android. If enable download home v2, thumbnail won't show. Previously thumbnail size passed to ThumbnailRequestGlue is hard coded value, which matches the size of the image/video card thumbnail view. Currently the size of thumbnail is 0 since we bind the current width and height of the view holder before the actual layout happens.
,
Sep 28
,
Sep 28
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7acc9abfee53e732b64ba83ddf057a895e1b2652 commit 7acc9abfee53e732b64ba83ddf057a895e1b2652 Author: Xing Liu <xingliu@chromium.org> Date: Tue Oct 02 18:11:22 2018 Download Home V2: Fix an issue that thumbnails are scaled to 0. Currently the AsyncImageView starts to retrieve thumbnails when the view holders are binded before the actual layout happens, which results in the width and height in thumbnail requests to be 0. This CL delays the thumbnail request after the actual layout happens. Also uses centerCrop for image and video view holders. Bug: 890377 Change-Id: I98f3864027553614a40d8211ac72743e66929db5 Reviewed-on: https://chromium-review.googlesource.com/c/1255586 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#595910} [modify] https://crrev.com/7acc9abfee53e732b64ba83ddf057a895e1b2652/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/ImageViewHolder.java [modify] https://crrev.com/7acc9abfee53e732b64ba83ddf057a895e1b2652/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/VideoViewHolder.java [modify] https://crrev.com/7acc9abfee53e732b64ba83ddf057a895e1b2652/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/view/AsyncImageView.java [modify] https://crrev.com/7acc9abfee53e732b64ba83ddf057a895e1b2652/ui/android/java/src/org/chromium/ui/widget/RoundedCornerImageView.java
,
Oct 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by xingliu@chromium.org
, Sep 28Owner: ----
Status: Available (was: Started)