mash: some interactive_ui_tests CHECK failed for ime.mojom |
|||
Issue descriptionThese are failing with single_process_mash_interactive_ui_tests BrowserFocusTest.TabsRememberFocus BrowserCommandControllerInteractiveTest.ShortcutsShouldTakeEffectInWindowMode KeyboardAccessTest.ReserveKeyboardAccelerators BrowserFocusTest.FocusTraversal BrowserViewFocusTest.TabChangesAvoidSpuriousFocus OmniboxViewTest.AltEnter A sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934169012929340496/+/steps/single_process_mash_interactive_ui_tests/0/stdout They say: [18340:18340:0927/215722.769006:FATAL:ime.mojom.cc(719)] Check failed: !connected. InputMethod::ProcessKeyEventCallback was destroyed without first either being run or its corresponding binding being closed. It is an error to drop response callbacks which still correspond to an open interface pipe. Maybe some cleanup is missing on tests?
,
Sep 28
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/547d9df6678dbae9a5387bc158ec526140fa5dab commit 547d9df6678dbae9a5387bc158ec526140fa5dab Author: Scott Violet <sky@chromium.org> Date: Fri Sep 28 22:55:30 2018 mash ime: ensure callbacks are run before closing pipe Otherwise we hit DCHECKs, and likely leave the remote side in a bad state. BUG= 890370 TEST=covered by tests Change-Id: Ibb903bf6fe6c67081e18459a142c7c67da0b2ac5 Reviewed-on: https://chromium-review.googlesource.com/1252639 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#595244} [modify] https://crrev.com/547d9df6678dbae9a5387bc158ec526140fa5dab/chrome/browser/ui/views/ime_driver/remote_text_input_client.cc [modify] https://crrev.com/547d9df6678dbae9a5387bc158ec526140fa5dab/chrome/browser/ui/views/ime_driver/remote_text_input_client.h [modify] https://crrev.com/547d9df6678dbae9a5387bc158ec526140fa5dab/content/browser/renderer_host/render_widget_host_view_aura.cc
,
Oct 1
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sky@chromium.org
, Sep 28