New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 890360 link

Starred by 2 users
Status: Fixed
Owner:
agrieve@chromium.org
Closed: Oct 1
Cc:
█ abenner@google.com
█ wnwen@chromium.org
pshmakov@chromium.org
estevenson@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

cs.chromium.org does not search Java .srcjars

Project Member Reported by agrieve@chromium.org, Sep 28 
It's pretty reasonable that codesearch doesn't search within .srcjar files, and I think it'd be pretty easy to fix: Just extract the .srcjar into //out/Debug/gen somewhere.

We should do the same for annotation processor output.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0567449ec64448720fbba3bea22e524c36e0dab

commit d0567449ec64448720fbba3bea22e524c36e0dab
Author: Andrew Grieve <agrieve@chromium.org>
Date: Fri Sep 28 21:10:18 2018

Android: Archive .srcjar and annotation processor .java files for codesearch

Bug:  890360 
Change-Id: I9ec730922415edf59e1878f89f9a046e5d1cc811
Reviewed-on: https://chromium-review.googlesource.com/1252006
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595215}
[modify] https://crrev.com/d0567449ec64448720fbba3bea22e524c36e0dab/build/android/gyp/jar.py
[modify] https://crrev.com/d0567449ec64448720fbba3bea22e524c36e0dab/build/android/gyp/javac.py
[modify] https://crrev.com/d0567449ec64448720fbba3bea22e524c36e0dab/build/config/android/internal_rules.gni
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b31cd7cf8a3242b108d07a6895f8d3955781eb3b

commit b31cd7cf8a3242b108d07a6895f8d3955781eb3b
Author: Andrew Grieve <agrieve@chromium.org>
Date: Mon Oct 01 22:48:28 2018

Android: Fix java builds failing when enabled_incremental_javac=true

Regressed in recent commit: d056744

Bug:  890360 
Change-Id: I1589295c40eff98a6255d9dd01ad9c2a66817dc4
Reviewed-on: https://chromium-review.googlesource.com/1255888
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595614}
[modify] https://crrev.com/b31cd7cf8a3242b108d07a6895f8d3955781eb3b/build/android/gyp/javac.py
►

Sign in to add a comment