New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 890349 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 846432



Sign in to add a comment

Please update depot_tools' yapf 0.22 -> 0.24

Project Member Reported by agrieve@chromium.org, Sep 28

Issue description

Looks like what's involved here is to:
1) Upload v0.24 to cipd here: infra/python/wheels/yapf-py2_py3
2) Tag it with: version:0.24.0
3) Update the vpython comment within depot_tools/yapf

I can send a CL to do #3, but need someone from infra to create the cipd package.
 
Status: Untriaged (was: Assigned)
Marking untriaged for the bug to show up in the queue.
Components: Infra>Platform>Admin
Cc: iannucci@chromium.org
+robbie: Should this go in the old third party packager or the new third party packager?
Neither; the 3pp packagers aren't currently used for vpython wheels.

The correct thing to do is to add another line to https://chromium.googlesource.com/infra/infra/+/master/infra/tools/dockerbuild/wheel.py#441 and run dockerbuild to package and upload the wheel.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/10f65fef63b27a78edb89bb64a330622665d1468

commit 10f65fef63b27a78edb89bb64a330622665d1468
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Tue Oct 09 20:33:49 2018

[dockerbuild] Add yapf 0.24.0 vpython wheel.

BUG= 890349 

Change-Id: I7755fe3c2f9fe0957c2d27e01b1e588f617a9212
Reviewed-on: https://chromium-review.googlesource.com/c/1271237
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Auto-Submit: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18192}
[modify] https://crrev.com/10f65fef63b27a78edb89bb64a330622665d1468/infra/tools/dockerbuild/wheel.py
[modify] https://crrev.com/10f65fef63b27a78edb89bb64a330622665d1468/infra/tools/dockerbuild/wheels.md

Owner: jchin...@chromium.org
Status: Started (was: Untriaged)
Andrew, would you please confirm whether you now have the desired version of yapf? Thanks!
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/db1e69ef0345752628872b7ff38a79240fa57201

commit db1e69ef0345752628872b7ff38a79240fa57201
Author: Aiden Benner <abenner@google.com>
Date: Tue Oct 09 22:20:23 2018

Update yapf version 0.22 -> 0.24

0.24 has just been uploaded see bug.

Bug:  890349 
Change-Id: Ice1e0c54d3fb60c0da5fde14aafae20c3ac449ce
Reviewed-on: https://chromium-review.googlesource.com/c/1261756
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aiden Benner <abenner@google.com>

[modify] https://crrev.com/db1e69ef0345752628872b7ff38a79240fa57201/yapf

Status: Verified (was: Started)
Thanks!
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41ef4d66feba41eca74cf23ebdf4e9560bb27939

commit 41ef4d66feba41eca74cf23ebdf4e9560bb27939
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Oct 10 01:23:37 2018

Roll src/third_party/depot_tools dce747620a14..db1e69ef0345 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dce747620a14..db1e69ef0345


git log dce747620a14..db1e69ef0345 --date=short --no-merges --format='%ad %ae %s'
2018-10-09 abenner@google.com Update yapf version 0.22 -> 0.24


Created with:
  gclient setdep -r src/third_party/depot_tools@db1e69ef0345

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:890349 
TBR=agable@chromium.org

Change-Id: Ia2c4216250337e6bb864d44c0ed4afca07deb9a9
Reviewed-on: https://chromium-review.googlesource.com/c/1271982
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#598166}
[modify] https://crrev.com/41ef4d66feba41eca74cf23ebdf4e9560bb27939/DEPS

Sign in to add a comment