New issue
Advanced search Search tips

Issue 890348 link

Starred by 2 users
Status: Fixed
Owner:
tienmai@chromium.org
Closed: Nov 27
Cc:
grt@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Add crashpad support to credential_provider

Project Member Reported by rogerta@chromium.org, Sep 28 
Add crashpad support to the credential_provider's setup program as CP DLL.

USeful info:
The details vary by use case. setup.exe spawns itself to run an embedded handler; see wWinMain in c/installer/setup/setup_main.cc -- it uses crash_reporter::RunAsCrashpadHandler in the spawned proc and crash_reporter::InitializeCrashpadWithEmbeddedHandler to do the respawn. I suggest looping in scottmg or another third_party/crashpad OWNER to see what the best way to do things is. You'll need a way for users to provide consent to upload crashes, a place to store the crashpad database and crashes, etc.

Comment 1 by yini...@chromium.org, Oct 2

Components: -Enterprise
I don't feel this is Enterprise related bug. 
rogerta@, can you enter another component?

Comment 2 by rogerta@chromium.org, Oct 5

Labels: gcpw

Comment 3 by rogerta@chromium.org, Oct 5 

The credential provider is an enterprise feature.  I added a label but I'll look into a component.

Comment 4 by rogerta@chromium.org, Oct 15

Components: Enterprise>CredentialProvider

Comment 5 by rogerta@chromium.org, Oct 15

Labels: -gcpw

Comment 6 by rogerta@chromium.org, Oct 16

Labels: Hotlist-Enterprise-Fixit

Comment 7 by rogerta@chromium.org, Oct 16

Status: Assigned (was: Untriaged)

Comment 8 by tienmai@chromium.org, Nov 13

Owner: tienmai@chromium.org
Status: Started (was: Assigned)

Comment 9 by tienmai@chromium.org, Nov 16

Status: Assigned (was: Started)

Comment 10 by tienmai@google.com, Nov 21

Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a2d5519c69e195e584055b186789b7f760c9703

commit 6a2d5519c69e195e584055b186789b7f760c9703
Author: Tien Mai <tienmai@chromium.org>
Date: Tue Nov 27 18:06:38 2018

Implement crashpad support for GCPW

- Implements crashpad support for GCPW installer
- Implements crashpad support for the actual credential provider dll
and runs the crashpad handler directly in the dll as an entry point

Bug:  890348 
Change-Id: I5b256b4d6ad8ee7153fd22e4d13f1a1791fa6d65
Reviewed-on: https://chromium-review.googlesource.com/c/1344210
Commit-Queue: Tien Mai <tienmai@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611187}
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/DEPS
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/common/gcp_strings.cc
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/common/gcp_strings.h
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/gaiacp/BUILD.gn
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/gaiacp/dllmain.cc
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/gaiacp/gaia_credential_base.cc
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/gaiacp/gaia_credential_provider.def
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/gaiacp/gaia_credential_provider_module.cc
[add] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/gaiacp/gcp_crash_reporter_client.cc
[add] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/gaiacp/gcp_crash_reporter_client.h
[add] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/gaiacp/gcp_crash_reporting.cc
[add] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/gaiacp/gcp_crash_reporting.h
[add] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/gaiacp/gcp_crash_reporting_utils.cc
[add] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/gaiacp/gcp_crash_reporting_utils.h
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/gaiacp/gcp_utils.cc
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/gaiacp/gcp_utils.h
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/gaiacp/os_process_manager.cc
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/setup/BUILD.gn
[add] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/setup/gcp_installer_crash_reporting.cc
[add] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/setup/gcp_installer_crash_reporting.h
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/chrome/credential_provider/setup/setup.cc
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/components/crash/content/app/crashpad.cc
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/components/crash/content/app/crashpad.h
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/components/crash/content/app/crashpad_linux.cc
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/components/crash/content/app/crashpad_mac.mm
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/components/crash/content/app/crashpad_win.cc
[modify] https://crrev.com/6a2d5519c69e195e584055b186789b7f760c9703/third_party/crashpad/crashpad/client/crashpad_client_win.cc

Comment 12 by tienmai@chromium.org, Nov 27

Status: Fixed (was: Started)
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a378c4d36bd69f4e2a7b90a4c44aa8accab76752

commit a378c4d36bd69f4e2a7b90a4c44aa8accab76752
Author: Tien Mai <tienmai@chromium.org>
Date: Mon Dec 03 20:17:06 2018

Fix flaky build caused by missing dependency in GCPW.

Bug:  890348 
Change-Id: I9946191164b4e9f8fde4be3452d80d866317b156
Reviewed-on: https://chromium-review.googlesource.com/c/1354693
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613211}
[modify] https://crrev.com/a378c4d36bd69f4e2a7b90a4c44aa8accab76752/chrome/credential_provider/gaiacp/BUILD.gn
►

Sign in to add a comment