New issue
Advanced search Search tips

Issue 890336 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Drop "Smart Lock"

Project Member Reported by vasi...@chromium.org, Sep 28

Issue description

"Smart Lock" brand should be removed from the password manager. This is a follow-up to Issue 862269.
 
Cc: maxwalker@chromium.org
iOS first screenshots. The footer is to be added.
Simulator Screen Shot - iPhone XR - 2018-09-28 at 15.53.45.png
102 KB View Download
Simulator Screen Shot - iPhone XR - 2018-09-28 at 15.49.40.png
102 KB View Download
Simulator Screen Shot - iPhone XR - 2018-09-28 at 15.49.26.png
102 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86b619d1203ff2c49f1a3500dc578a7faad838d4

commit 86b619d1203ff2c49f1a3500dc578a7faad838d4
Author: vasilii <vasilii@chromium.org>
Date: Fri Sep 28 15:14:30 2018

Change the titles of Save/Update password infobar on iOS.

The CL lands the necessary strings for iOS. A pending task is to add a footer for the Sync users.

Bug:  890336 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I47732fa83287439b40c52ed37ac6850b2986ab41
Reviewed-on: https://chromium-review.googlesource.com/1251547
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595097}
[modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/app/strings/ios_chromium_strings.grd
[modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/app/strings/ios_google_chrome_strings.grd
[modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.h
[modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.mm
[modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.h
[modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm
[modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.h
[modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm
[modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/update_password_infobar_controller.mm

Desktop first pass
Screen Shot 2018-09-28 at 19.09.17.png
19.2 KB View Download
Screen Shot 2018-09-28 at 19.00.56.png
17.5 KB View Download
Screen Shot 2018-09-28 at 19.00.07.png
19.5 KB View Download
Android 
Screenshot_1538159688.png
170 KB View Download
Screenshot_1538159639.png
160 KB View Download
Screenshot_1538159548.png
253 KB View Download
Screenshot_1538159727.png
249 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b05b2188f20f55bd658e0589bee0c0114f91661b

commit b05b2188f20f55bd658e0589bee0c0114f91661b
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Sep 28 19:48:54 2018

Remove the "Smart Lock" branding from the Credential Manager API.

Bug:  890336 
Change-Id: I649336ca32aa4b23b8859a06f44bdf8dc7a6da26
Reviewed-on: https://chromium-review.googlesource.com/1251464
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595185}
[modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/app/generated_resources.grd
[modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/password_manager/account_chooser_dialog_android.cc
[modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc
[modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/password_manager/save_password_infobar_delegate_android.cc
[modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/password_manager/update_password_infobar_delegate_android.cc
[modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
[modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
[modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
[modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/ui/passwords/manage_passwords_view_utils.h
[modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
[modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/ui/passwords/password_dialog_controller_impl.cc
[modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/ui/passwords/password_dialog_controller_impl.h

Comment 6 Deleted

Mocks https://docs.google.com/presentation/d/1PaDwWccOg2AyviHh3d0sPKo-wMDMfBRQ8rQwL_yiX8Q/edit#slide=id.g3a6e304912_1_14


Screenshot from 2018-10-05 19-54-28.png
18.3 KB View Download
Screenshot from 2018-10-05 19-54-40.png
11.7 KB View Download
Screenshot from 2018-10-05 20-01-56.png
16.1 KB View Download
Screenshot from 2018-10-05 20-32-12.png
19.4 KB View Download
Screenshot from 2018-10-05 20-46-39.png
11.9 KB View Download
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a98a17c068a33fac936c1eecde53fd82ba2781f

commit 9a98a17c068a33fac936c1eecde53fd82ba2781f
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Oct 08 15:21:31 2018

Deprecate "Smart Lock" in the native UI on desktop.

The CL changes the layout of the "Save username?" bubble. It is used for
federated credentials.
The "Save password/username?" bubble has always a footer for the signed-in users.
The footer is now shown in the account chooser for the signed-in users.

Bug:  890336 
Change-Id: I7133cb15c6377e82e971e793886f8520b5bfd4eb
Reviewed-on: https://chromium-review.googlesource.com/c/1265259
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597565}
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/app/generated_resources.grd
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/password_dialog_controller.h
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/password_dialog_controller_impl.cc
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/password_dialog_controller_impl.h
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/password_dialog_controller_mock.h
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/passwords_model_delegate.h
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/passwords_model_delegate_mock.h
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/views/passwords/account_chooser_dialog_view.h
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.h
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/views/passwords/password_pending_view.cc
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/views/passwords/password_pending_view.h
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/common/url_constants.cc
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/common/url_constants.h
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/components/password_manager/core/browser/password_manager_metrics_util.h
[modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/tools/metrics/histograms/enums.xml

Simulator Screen Shot - iPhone XR - 2018-10-09 at 19.07.09.png
116 KB View Download
Simulator Screen Shot - iPhone XR - 2018-10-09 at 19.06.41.png
118 KB View Download
Simulator Screen Shot - iPhone XR - 2018-10-09 at 18.51.56.png
103 KB View Download
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4394d66ff109168770d9af89be1dc61a52fbf3e2

commit 4394d66ff109168770d9af89be1dc61a52fbf3e2
Author: vasilii <vasilii@chromium.org>
Date: Thu Oct 11 15:51:17 2018

Add a footer to the "Save password?" infobar.

It appears for the Chrome Sync users.

Bug:  890336 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I0a443b3d29670c00c28a847d6d2253db3a620996
Reviewed-on: https://chromium-review.googlesource.com/c/1270922
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598780}
[modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.h
[modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.mm
[modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm
[modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm
[add] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/ios_password_infobar_controller.h
[add] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/ios_password_infobar_controller.mm
[modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/update_password_infobar_controller.h
[modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/ui/infobars/confirm_infobar_view.h
[modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/ui/infobars/confirm_infobar_view.mm

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b6016fba9fe8d6a5a7d2b13de035b34eb16d303

commit 7b6016fba9fe8d6a5a7d2b13de035b34eb16d303
Author: vasilii <vasilii@chromium.org>
Date: Fri Oct 12 10:00:59 2018

Rename the iVars in confirm_infobar_view.mm to match the style guide.

It's a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1270922

Bug:  890336 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iea3b7be1d588cdcdbdded5409927e18c069812b4
Reviewed-on: https://chromium-review.googlesource.com/c/1277287
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599156}
[modify] https://crrev.com/7b6016fba9fe8d6a5a7d2b13de035b34eb16d303/ios/chrome/browser/ui/infobars/confirm_infobar_view.mm

Status: Fixed (was: Started)

Sign in to add a comment