"Smart Lock" brand should be removed from the password manager. This is a follow-up to Issue 862269.
iOS first screenshots. The footer is to be added.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86b619d1203ff2c49f1a3500dc578a7faad838d4 commit 86b619d1203ff2c49f1a3500dc578a7faad838d4 Author: vasilii <vasilii@chromium.org> Date: Fri Sep 28 15:14:30 2018 Change the titles of Save/Update password infobar on iOS. The CL lands the necessary strings for iOS. A pending task is to add a footer for the Sync users. Bug: 890336 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I47732fa83287439b40c52ed37ac6850b2986ab41 Reviewed-on: https://chromium-review.googlesource.com/1251547 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595097} [modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/app/strings/ios_chromium_strings.grd [modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/app/strings/ios_google_chrome_strings.grd [modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.h [modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.mm [modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.h [modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm [modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.h [modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm [modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/password_controller.mm [modify] https://crrev.com/86b619d1203ff2c49f1a3500dc578a7faad838d4/ios/chrome/browser/passwords/update_password_infobar_controller.mm
Desktop first pass
Android
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b05b2188f20f55bd658e0589bee0c0114f91661b commit b05b2188f20f55bd658e0589bee0c0114f91661b Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Fri Sep 28 19:48:54 2018 Remove the "Smart Lock" branding from the Credential Manager API. Bug: 890336 Change-Id: I649336ca32aa4b23b8859a06f44bdf8dc7a6da26 Reviewed-on: https://chromium-review.googlesource.com/1251464 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#595185} [modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/app/generated_resources.grd [modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/password_manager/account_chooser_dialog_android.cc [modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc [modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/password_manager/save_password_infobar_delegate_android.cc [modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/password_manager/update_password_infobar_delegate_android.cc [modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc [modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h [modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/ui/passwords/manage_passwords_view_utils.cc [modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/ui/passwords/manage_passwords_view_utils.h [modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc [modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/ui/passwords/password_dialog_controller_impl.cc [modify] https://crrev.com/b05b2188f20f55bd658e0589bee0c0114f91661b/chrome/browser/ui/passwords/password_dialog_controller_impl.h
Mocks https://docs.google.com/presentation/d/1PaDwWccOg2AyviHh3d0sPKo-wMDMfBRQ8rQwL_yiX8Q/edit#slide=id.g3a6e304912_1_14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a98a17c068a33fac936c1eecde53fd82ba2781f commit 9a98a17c068a33fac936c1eecde53fd82ba2781f Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Mon Oct 08 15:21:31 2018 Deprecate "Smart Lock" in the native UI on desktop. The CL changes the layout of the "Save username?" bubble. It is used for federated credentials. The "Save password/username?" bubble has always a footer for the signed-in users. The footer is now shown in the account chooser for the signed-in users. Bug: 890336 Change-Id: I7133cb15c6377e82e971e793886f8520b5bfd4eb Reviewed-on: https://chromium-review.googlesource.com/c/1265259 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#597565} [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/app/generated_resources.grd [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/manage_passwords_bubble_model.h [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/manage_passwords_ui_controller.h [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/manage_passwords_view_utils.cc [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/password_dialog_controller.h [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/password_dialog_controller_impl.cc [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/password_dialog_controller_impl.h [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/password_dialog_controller_mock.h [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/passwords_model_delegate.h [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/passwords/passwords_model_delegate_mock.h [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/views/passwords/account_chooser_dialog_view.h [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.h [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/views/passwords/password_pending_view.cc [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/browser/ui/views/passwords/password_pending_view.h [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/common/url_constants.cc [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/chrome/common/url_constants.h [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/components/password_manager/core/browser/password_form_metrics_recorder.cc [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/components/password_manager/core/browser/password_manager_metrics_util.h [modify] https://crrev.com/9a98a17c068a33fac936c1eecde53fd82ba2781f/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4394d66ff109168770d9af89be1dc61a52fbf3e2 commit 4394d66ff109168770d9af89be1dc61a52fbf3e2 Author: vasilii <vasilii@chromium.org> Date: Thu Oct 11 15:51:17 2018 Add a footer to the "Save password?" infobar. It appears for the Chrome Sync users. Bug: 890336 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0a443b3d29670c00c28a847d6d2253db3a620996 Reviewed-on: https://chromium-review.googlesource.com/c/1270922 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#598780} [modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/BUILD.gn [modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.h [modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.mm [modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm [modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm [add] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/ios_password_infobar_controller.h [add] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/ios_password_infobar_controller.mm [modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/passwords/update_password_infobar_controller.h [modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/ui/infobars/confirm_infobar_view.h [modify] https://crrev.com/4394d66ff109168770d9af89be1dc61a52fbf3e2/ios/chrome/browser/ui/infobars/confirm_infobar_view.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b6016fba9fe8d6a5a7d2b13de035b34eb16d303 commit 7b6016fba9fe8d6a5a7d2b13de035b34eb16d303 Author: vasilii <vasilii@chromium.org> Date: Fri Oct 12 10:00:59 2018 Rename the iVars in confirm_infobar_view.mm to match the style guide. It's a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1270922 Bug: 890336 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iea3b7be1d588cdcdbdded5409927e18c069812b4 Reviewed-on: https://chromium-review.googlesource.com/c/1277287 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#599156} [modify] https://crrev.com/7b6016fba9fe8d6a5a7d2b13de035b34eb16d303/ios/chrome/browser/ui/infobars/confirm_infobar_view.mm
Verified on 71.0.3578.77 beta on iOS. New infobars matches with the screenshots given in comment#9. Device: iPhoneXS, iOS: 12.1.1
Comment 1 by vasi...@chromium.org
, Sep 28102 KB
102 KB View Download
102 KB
102 KB View Download
102 KB
102 KB View Download