Multiple virtual/layout_ng_experimental/fast/multicol/ failures. |
|||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of fdoray@google.com --- Sample failed build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/3698 Unexpected Failures: * virtual/layout_ng_experimental/fast/multicol/balance-float-with-margin-top-and-line-after-break.html * virtual/layout_ng_experimental/fast/multicol/dynamic/remove-abspos-next-to-spanner.html
,
Sep 28
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b33b53351841caa993e404712c7eda7e42a2668 commit 2b33b53351841caa993e404712c7eda7e42a2668 Author: Koji Ishii <kojii@chromium.org> Date: Fri Sep 28 18:17:10 2018 Reland "[LayoutNG] Make constraint space for column balancing intermediate" This is a reland of 5cae37b5f84223f8f361d3dfaf639d6b85fdf37b Two tests that were changed from Failure to Crash turned out to be flaky, they do not crash on linux-xenial-rel. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/3698 Original change's description: > [LayoutNG] Make constraint space for column balancing intermediate > > Fragment caching and paint needs to know if fragments created > for a constraint space are for the regular layout that are to > be painted, or it's for intermediate computation. > > Since the layout results for column balancing should not be > painted, this patch marks so. > > This change alone doesn't fix all weird paint data > inconsistencies when block fragmentation is turned on. Other > issues need further investigation. > > Bug: 714962 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: I14d44ca10fd23726f2c08be45b10c2b0abe16bf7 > Reviewed-on: https://chromium-review.googlesource.com/1250685 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595051} TBR=mstensho@chromium.org Bug: 714962 , 890326 Change-Id: I3ed406ee0ab34f63e3c5b6a7352dac44274014f9 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1251682 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595159} [modify] https://crrev.com/2b33b53351841caa993e404712c7eda7e42a2668/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/2b33b53351841caa993e404712c7eda7e42a2668/third_party/blink/renderer/core/layout/ng/ng_column_layout_algorithm.cc
,
Sep 28
|
|||
►
Sign in to add a comment |
|||
Comment 1 by fdoray@chromium.org
, Sep 28