New issue
Advanced search Search tips

Issue 890325 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Android binary size alerts broken

Project Member Reported by estevenson@chromium.org, Sep 28

Issue description

+some folks from  issue 831328 

Seems like binary size alerts aren't firing again. Large commit with no alert: https://chromeperf.appspot.com/report?sid=d6542096534166992e063320f8e1b7128e10ed53091e865eef3b5295644e60ce&rev=594853

I've recently been working on the binary size trybot but I haven't changed the api used to create the results.json for these alerts.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/98289bcecf60590683b9adb7dc05de31dc9dd6cf

commit 98289bcecf60590683b9adb7dc05de31dc9dd6cf
Author: Simon <simonhatch@chromium.org>
Date: Fri Sep 28 22:39:53 2018

Dashboard - Add missing index for querying last alert.

TBR=eakuefner@chromium.org
Bug:  chromium:890325 
Change-Id: I61d248c3c9b7d85a5a911aacafcefda4b05e7ee4
Reviewed-on: https://chromium-review.googlesource.com/1252283
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/98289bcecf60590683b9adb7dc05de31dc9dd6cf/dashboard/index.yaml

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0ac64f08cdcc2d964a60be45db795505784d931

commit f0ac64f08cdcc2d964a60be45db795505784d931
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Sat Sep 29 19:17:06 2018

Roll src/third_party/catapult d525ef309fca..98289bcecf60 (5 commits)

https://chromium.googlesource.com/catapult.git/+log/d525ef309fca..98289bcecf60


git log d525ef309fca..98289bcecf60 --date=short --no-merges --format='%ad %ae %s'
2018-09-28 simonhatch@chromium.org Dashboard - Add missing index for querying last alert.
2018-09-28 chiniforooshan@chromium.org Telemetry: cpu_per_frame metrics in TBMv2
2018-09-28 manojgupta@google.com benchmark_runner: Emit all stories in a benchmark.
2018-09-28 dtu@chromium.org [pinpoint] Don't set difference_count for try jobs.
2018-09-28 jbudorick@chromium.org devil: remove host arm build rules.


Created with:
  gclient setdep -r src/third_party/catapult@98289bcecf60

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:890325 ,chromium:760553, chromium:888551 , chromium:888114 , chromium:890041 , chromium:887888 
TBR=sullivan@chromium.org

Change-Id: I25e06429f53579449a9ebd2d1ba948ff6409f4e7
Reviewed-on: https://chromium-review.googlesource.com/1252266
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595322}
[modify] https://crrev.com/f0ac64f08cdcc2d964a60be45db795505784d931/DEPS

Status: Fixed (was: Started)
Thanks Simon!

Sign in to add a comment