New issue
Advanced search Search tips

Issue 890323 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 746956



Sign in to add a comment

Support jumbo in chrome/common

Project Member Reported by brat...@opera.com, Sep 28

Issue description

Jumbo compilations makes for more efficient compilations by compiling several files together in a single compiler invocation. This is helpful for those without massively parallel build systems.
 
Blocking: 746956
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e491595def066c5c3ecda74453ead7f553f702d

commit 3e491595def066c5c3ecda74453ead7f553f702d
Author: Daniel Bratell <bratell@opera.com>
Date: Tue Oct 02 08:52:36 2018

Avoid having two global GetInfo() methods in the same module

In jumbo builds a whole build target can compile together
and share the same anonymous namespace. Then two methods with
the same name and arguments will clash which happens in
chrome/common.

This resolves that clash twice over by giving one GetInfo a
longer name and inlining the other one since it was only used
once in a one line function.

Bug: 890323
Change-Id: Icbb1d768bdf9c1385f35bebd54d0d008e4be49d9
Reviewed-on: https://chromium-review.googlesource.com/1251603
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#595765}
[modify] https://crrev.com/3e491595def066c5c3ecda74453ead7f553f702d/chrome/common/extensions/manifest_handlers/app_icon_color_info.cc
[modify] https://crrev.com/3e491595def066c5c3ecda74453ead7f553f702d/chrome/common/extensions/manifest_handlers/linked_app_icons.cc

Sign in to add a comment