Check cleaners are correctly created |
|||
Issue descriptionRemoveUselessCredential function from password_manager_utils.cc create cleaners and insert them in the cleaner runner's queue. Unittests should be added in password_manager_util_unittest.cc to check that cleaners are correctly created relying on the associated preference of the cleaner.
,
Sep 28
To clarify: the associated preferences for each cleaner record whether it was run. To verify that RemoveUselessCredential attempted to run the correct cleaners, the test only needs to check that it transforms the initial state of the prefs into the expected exit state. There is no need to actually check the result of the clean-ups, that is done by the cleaners' tests (here the PasswordStore can be empty).
,
Nov 29
vabr going hobby only -> reducing involvement. Please contact me directly in urgent matters. |
|||
►
Sign in to add a comment |
|||
Comment 1 by gemene@google.com
, Sep 28