New issue
Advanced search Search tips

Issue 890313 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

TaskManagerBrowserTests failing on Linux ChromiumOS MSan Tests and Linux MSan Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Sep 28

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of clamy@google.com

single_process_mash_browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests

Builders failed on: 
- Linux ChromiumOS MSan Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests


 
The tests that are failing:
TaskManagerBrowserTest.TotalSentDataObserved
TaskManagerBrowserTest.SentDataObserved

They are also failing on LinuxMSAN.
Summary: *browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests (was: single_process_mash_browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests)
Not that I'm currently running a manual bisect since findit points to multiple culprit CLs.
So after investigating, it seems both tests take just a little too long to run when MSAN is enabled, so both time out. I'm going to disable them when MSAN is enabled.
Summary: TaskManagerBrowserTests failing on Linux ChromiumOS MSan Tests and Linux MSan Tests (was: *browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests)
Owner: afakhry@chromium.org
Assigning to afakhry@ as an owner of chrome/browser/task/managers.
CL for disabling the two tests in review at https://chromium-review.googlesource.com/c/chromium/src/+/1251453.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab70ca4f282e87841287ffe1c8e8b44a2d04dff3

commit ab70ca4f282e87841287ffe1c8e8b44a2d04dff3
Author: Camille Lamy <clamy@chromium.org>
Date: Fri Sep 28 16:42:15 2018

Disable 2 TaskManagerBrowserTests when MSan is enabled

They are taking too long to run and timeout when run with MSan.

TBR=jam@chromium.org

Bug: 890313
Change-Id: Ib7d1f3d6edcb62adcddbc54a0c636a9aae37d002
Reviewed-on: https://chromium-review.googlesource.com/1251453
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595120}
[modify] https://crrev.com/ab70ca4f282e87841287ffe1c8e8b44a2d04dff3/chrome/browser/task_manager/task_manager_browsertest.cc

Components: UI>TaskManager
Labels: -Sheriff-Chromium
Removing from sheriff queue since the tests were disabled. Please fix and re-enable them afakhry@ :)
Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked

Sign in to add a comment