New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 890298 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

RenderTextHarfBuzz never evicts items from its font cache

Project Member Reported by thakis@chromium.org, Sep 28

Issue description

https://cs.chromium.org/chromium/src/ui/gfx/harfbuzz_font_skia.cc?type=cs&q=CreateHarfBuzzFont&sq=package:chromium&g=0&l=288

  // TODO(ckocagil): This shouldn't grow indefinitely. Maybe use base::MRUCache?
  static std::map<SkFontID, FaceCache> face_caches;


As far as I can tell this function is only called from the browser process so the set of fonts passed in is pretty limited, but there are many callers and the code is in ui/, so it's not unthinkable that it's going to be used from the renderer process, where webfonts means this cache could grow arbitrarily large over time.
 
Status: Available (was: Untriaged)
Can I take a look at this issue?
It just looks like replace face_cache into base::MRUCache.
Is it right?
Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked

Sign in to add a comment