[ozone/wayland] Youtube videos crash. |
||
Issue descriptionWhen the Chromium with Ozone/Wayland is being used with YouTube, it immediately crashes. Reason: buffer formats used by the client are not supported by the Wayland drm implementation. That is, the Wayland compositor usually announces supported drm buffer formats when zwp_linux_dmabuf interface is bound, but some compositors do not do so (maybe a bug in them??). Thus, the assumption we have in the client_native_pixmap_factory_wayland.cc, which assumes/guesses a buffer format is supported, when those are not announced, is wrong. And it leads to an immediate crash. Fix: remove that assumption and fallback to software usage. https://cs.chromium.org/chromium/src/ui/ozone/platform/wayland/client_native_pixmap_factory_wayland.cc?type=cs&g=0&l=28
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5669effdd543c07d7239cc9b01ab9b5d1d13dd05 commit 5669effdd543c07d7239cc9b01ab9b5d1d13dd05 Author: Maksim Sisov <msisov@igalia.com> Date: Mon Oct 01 13:15:36 2018 [ozone/wayland] Use only announced buffer formats. It turned out that it was not a good idea to try to guess buffer formats if a Wayland compositor had not announced supported buffer formats. If such a case happened (the Wayland compositor did not announce the formats), guessing them resulted in crashes in YouTube videos for example. Thus, it's better to fallback to software GpuMemoryBuffers rather than crashing. What is more, the Wayland spec says it must announce the supported formats once zwp_linux_dmabuf interface is bound, but in some versions of the compositors it does not happen. It looks more like a bug, which must be reported. Bug: 890284 Change-Id: I9bd20019709b0cbd82fa9654627b825adceb479b Reviewed-on: https://chromium-review.googlesource.com/1253641 Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#595436} [modify] https://crrev.com/5669effdd543c07d7239cc9b01ab9b5d1d13dd05/ui/ozone/platform/wayland/client_native_pixmap_factory_wayland.cc
,
Oct 1
|
||
►
Sign in to add a comment |
||
Comment 1 by msi...@igalia.com
, Sep 28Labels: -Pri-3 OS-Linux Pri-1