See the first failing builds here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/2542 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Release%20%28Intel%29/6848 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28NVIDIA%29/2571 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28AMD%29/2795 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Retina%20Release%20%28AMD%29/8042 Suspecting "[media] Fix video to canvas GPU-CPU race." https://chromium-review.googlesource.com/1244835 This is blocking the ANGLE CQ so will revert.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b39e1696cad4b7b661a91fe12e4fcc0aef45a9d3 commit b39e1696cad4b7b661a91fe12e4fcc0aef45a9d3 Author: Jamie Madill <jmadill@chromium.org> Date: Fri Sep 28 11:25:41 2018 Revert "[media] Fix video to canvas GPU-CPU race." This reverts commit 9803c0eb2761892ad1e6826f80a1b3597d6cea67. Reason for revert: WebGL 2 video test failures on Win/Mac. Blocking the ANGLE CQ. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/2542 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Release%20%28Intel%29/6848 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28NVIDIA%29/2571 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28AMD%29/2795 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Retina%20Release%20%28AMD%29/8042 Also reverts "[media] Fix video frame copy when context is lost." Bug: 890281 Original change's description: > [media] Fix video to canvas GPU-CPU race. > > VideoFrames marked with VideoFrameMetadata::READ_LOCK_FENCES_ENABLED > must be retained until all reads have been completed. Such frames are > produced when software frames are uploaded to GpuMemoryBuffers. The > VideoResourceUpdater handles this, but PaintCanvasVideoRenderer > implemented only sync tokens. > > As a result, WebGL reads of software-decoded frames can tear when the > storage is reused for later frames. > > This CL adds a GL_COMMANDS_COMPLETED_CHROMIUM query after each potential > VideoFrame read in PaintCanvasVideoRenderer, and retains a reference to > the VideoFrame until it completes. This ensures that the memory is not > reused until after the reads complete in the GPU process. > > Bug: 819914 > Change-Id: I3e6e5f83cff86beedbd76a406aa31c4eb84a0929 > Reviewed-on: https://chromium-review.googlesource.com/1244835 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594900} TBR=pfeldman@chromium.org,tedchoc@chromium.org,sandersd@chromium.org,dcastagna@chromium.org,sunnyps@chromium.org,piman@chromium.org Change-Id: Ib21a4879a9ca6fc4b84f6f2c2f1171c794db54b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819914 Reviewed-on: https://chromium-review.googlesource.com/1251321 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#595058} [modify] https://crrev.com/b39e1696cad4b7b661a91fe12e4fcc0aef45a9d3/chrome/browser/android/download/video_frame_thumbnail_converter.cc [modify] https://crrev.com/b39e1696cad4b7b661a91fe12e4fcc0aef45a9d3/chrome/browser/devtools/devtools_eye_dropper.h [modify] https://crrev.com/b39e1696cad4b7b661a91fe12e4fcc0aef45a9d3/content/browser/devtools/devtools_video_consumer.cc [modify] https://crrev.com/b39e1696cad4b7b661a91fe12e4fcc0aef45a9d3/content/renderer/media/stream/webmediaplayer_ms.cc [modify] https://crrev.com/b39e1696cad4b7b661a91fe12e4fcc0aef45a9d3/content/renderer/media/stream/webmediaplayer_ms_compositor.cc [modify] https://crrev.com/b39e1696cad4b7b661a91fe12e4fcc0aef45a9d3/content/renderer/media_recorder/video_track_recorder.cc [modify] https://crrev.com/b39e1696cad4b7b661a91fe12e4fcc0aef45a9d3/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/b39e1696cad4b7b661a91fe12e4fcc0aef45a9d3/media/renderers/paint_canvas_video_renderer.cc [modify] https://crrev.com/b39e1696cad4b7b661a91fe12e4fcc0aef45a9d3/media/renderers/paint_canvas_video_renderer.h [modify] https://crrev.com/b39e1696cad4b7b661a91fe12e4fcc0aef45a9d3/media/renderers/paint_canvas_video_renderer_unittest.cc [modify] https://crrev.com/b39e1696cad4b7b661a91fe12e4fcc0aef45a9d3/media/renderers/video_resource_updater.cc
Looks like the failures have cleared up. sandersd: if you want to test this before you re-land, you can use the win_angle_rel_ng trybot.
Comment 1 by bugdroid1@chromium.org
, Sep 28