Print dialog shows [Print using system dialog] |
||||
Issue descriptionGoogle Chrome 71.0.3558.0 (Official Build) dev (64-bit) Revision 09438e58ad92274e6fa5f7a76429836ceeba5fa5-refs/branch-heads/3558@{#1} Platform 11097.0.0 (Official Build) dev-channel eve Firmware Version Google_Eve.9584.171.0 What steps will reproduce the problem? 1. Attempt to print with a printer that doesn't work What is the expected result? ¯\_(ツ)_/¯ What happens instead of that? I get a button that says [Print using system dialog] -- but I am already using the system dialog.
,
Sep 28
rbpotter: We probably need to make sure "use system dialog" buttons don't show up on ChromeOS.
,
Sep 28
,
Sep 28
Consulted with namratakannan@ and we are going to just remove this button. It doesn't work (with the existing/old UI) on Windows, does not make sense, as reported here, on Chrome OS, and is rarely shown on Mac or Linux, which have the system dialog link available on the left hand panel anyway.
,
Sep 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b31ed0dd54be515dbc6bc19fef18c5e396b42a5 commit 9b31ed0dd54be515dbc6bc19fef18c5e396b42a5 Author: rbpotter <rbpotter@chromium.org> Date: Sat Sep 29 02:10:11 2018 Print Preview Refresh: Remove Preview Area system dialog button This button should not be shown on Chrome OS, since there is no system dialog on that platform. In the existing UI, it does not work on Windows, since Windows uses a unique print preview -> system dialog path. It is shown very infrequently on Mac and Linux, and these users will still have the "Print with system dialog" link on the sidebar available if this error state does occur. Bug: 890250 Change-Id: Icfaa4d173c34565b00fd754df3b9f204419c895a Reviewed-on: https://chromium-review.googlesource.com/1252624 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595289} [modify] https://crrev.com/9b31ed0dd54be515dbc6bc19fef18c5e396b42a5/chrome/browser/resources/print_preview/new/preview_area.html [modify] https://crrev.com/9b31ed0dd54be515dbc6bc19fef18c5e396b42a5/chrome/browser/resources/print_preview/new/preview_area.js
,
Oct 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dstockwell@google.com
, Sep 28