New issue
Advanced search Search tips

Issue 890237 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 5
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Eliminate stale PO2TS include from one_click_signin_sync_starter.cc

Project Member Reported by blundell@chromium.org, Sep 28

Issue description

Looks like PO2TS isn't actually used here.
 
Owner: ma...@igalia.com
Status: Started (was: Available)
CL here: https://chromium-review.googlesource.com/c/chromium/src/+/1251045
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5924a737804dd697cbbfc6bb6bf8fb5daef8b2d9

commit 5924a737804dd697cbbfc6bb6bf8fb5daef8b2d9
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Mon Oct 01 16:20:08 2018

Eliminate stale PO2TS includes from one_click_signin_sync_starter.cc

There are no references to either ProfileOAuth2TokenServiceFactory or
ProfileOAuth2TokenService, so these includes can be safely removed.

Bug:  890237 
Change-Id: If484fd41a20ef88b59a91777d741c368fc36ba17
Reviewed-on: https://chromium-review.googlesource.com/1251045
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#595462}
[modify] https://crrev.com/5924a737804dd697cbbfc6bb6bf8fb5daef8b2d9/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

Status: Fixed (was: Started)

Sign in to add a comment