Eliminate stale //components/signin includes from sms_service_factory.cc |
||
Issue descriptionI believe that SMSService no longer uses these classes; it should be possible to just eliminate these includes from the factory.
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf1594a94740a63040291bdaa77846fc7e32324a commit cf1594a94740a63040291bdaa77846fc7e32324a Author: Mario Sanchez Prada <mario@igalia.com> Date: Fri Sep 28 14:58:52 2018 Eliminate stale includes from sms_service_factory.cc Neither signin_manager.h nor profile_oauth2_token_service.h are being used from this implementation file, we can clean these includes up. Bug: 890236 Change-Id: I3d6e55bc63e5c6e43115de1e46022fdee404d83e Reviewed-on: https://chromium-review.googlesource.com/1251623 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#595092} [modify] https://crrev.com/cf1594a94740a63040291bdaa77846fc7e32324a/chrome/browser/ui/desktop_ios_promotion/sms_service_factory.cc
,
Sep 28
Resolving
,
Oct 1
Thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by ma...@igalia.com
, Sep 28Status: Started (was: Available)