New issue
Advanced search Search tips

Issue 890236 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 28
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318
issue 883330



Sign in to add a comment

Eliminate stale //components/signin includes from sms_service_factory.cc

Project Member Reported by blundell@chromium.org, Sep 28

Issue description

I believe that SMSService no longer uses these classes; it should be possible to just eliminate these includes from the factory.
 
Owner: ma...@igalia.com
Status: Started (was: Available)
CL here: https://chromium-review.googlesource.com/c/chromium/src/+/1251623
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf1594a94740a63040291bdaa77846fc7e32324a

commit cf1594a94740a63040291bdaa77846fc7e32324a
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Fri Sep 28 14:58:52 2018

Eliminate stale includes from sms_service_factory.cc

Neither signin_manager.h nor profile_oauth2_token_service.h are being
used from this implementation file, we can clean these includes up.

Bug:  890236 
Change-Id: I3d6e55bc63e5c6e43115de1e46022fdee404d83e
Reviewed-on: https://chromium-review.googlesource.com/1251623
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#595092}
[modify] https://crrev.com/cf1594a94740a63040291bdaa77846fc7e32324a/chrome/browser/ui/desktop_ios_promotion/sms_service_factory.cc

Status: Fixed (was: Started)
Resolving
Thanks!

Sign in to add a comment