New issue
Advanced search Search tips

Issue 890221 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 878028



Sign in to add a comment

Integrate SkiaVectorAnimation class with the UI framework

Project Member Reported by malaykeshav@chromium.org, Sep 28

Issue description

Now that was have phase 1 of SkiaVectorAnimation landed in Chrome, it needs to be integrated with the UI framework. Something similar to ImageView that we have for ImageSkia.

go/cros-skottie
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53c1dd90160fe939c9e3bb7690a0bb9f806caaf3

commit 53c1dd90160fe939c9e3bb7690a0bb9f806caaf3
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Mon Oct 08 19:30:17 2018

Integrates SkiaVectorAnimation with views

This patch integrates SkiaVectorAnimation class with the views
framework. Since most of the code is shared with ImageView, a new
virtual super class is introduced, ImageViewBase. AnimatedImageView is
added as a subclass of this virtual class.

For now the integration class is a very basic view that can play and
stop a given Skia vector animation at a custom size.

This patch also adds an example to views/examples to load animations
and play.

Design doc: go/cros-skottie

Bug:  890221 
Change-Id: I55d7310ef74cdfb825cce441c8e61eadff9c5616
Component: Views, examples, skottie, SkiaVectorAnimation
Reviewed-on: https://chromium-review.googlesource.com/c/1262967
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597646}
[modify] https://crrev.com/53c1dd90160fe939c9e3bb7690a0bb9f806caaf3/ui/views/BUILD.gn
[add] https://crrev.com/53c1dd90160fe939c9e3bb7690a0bb9f806caaf3/ui/views/controls/animated_image_view.cc
[add] https://crrev.com/53c1dd90160fe939c9e3bb7690a0bb9f806caaf3/ui/views/controls/animated_image_view.h
[modify] https://crrev.com/53c1dd90160fe939c9e3bb7690a0bb9f806caaf3/ui/views/controls/image_view.cc
[modify] https://crrev.com/53c1dd90160fe939c9e3bb7690a0bb9f806caaf3/ui/views/controls/image_view.h
[add] https://crrev.com/53c1dd90160fe939c9e3bb7690a0bb9f806caaf3/ui/views/controls/image_view_base.cc
[add] https://crrev.com/53c1dd90160fe939c9e3bb7690a0bb9f806caaf3/ui/views/controls/image_view_base.h
[modify] https://crrev.com/53c1dd90160fe939c9e3bb7690a0bb9f806caaf3/ui/views/examples/BUILD.gn
[add] https://crrev.com/53c1dd90160fe939c9e3bb7690a0bb9f806caaf3/ui/views/examples/animated_image_view_example.cc
[add] https://crrev.com/53c1dd90160fe939c9e3bb7690a0bb9f806caaf3/ui/views/examples/animated_image_view_example.h
[modify] https://crrev.com/53c1dd90160fe939c9e3bb7690a0bb9f806caaf3/ui/views/examples/examples_window.cc

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d10cd0c15fcca20cb4347169cabb84fd9831241e

commit d10cd0c15fcca20cb4347169cabb84fd9831241e
Author: Robert Liao <robliao@chromium.org>
Date: Wed Oct 24 22:24:45 2018

Short-circuit AnimatedImageView::Stop If The AnimatedImageView Was Never Started

AnimatedImageViews that never receive an animated image and are never
started should not DCHECK(animated_image_) at AnimatedImageView::Stop.

BUG= 890221 

Change-Id: I519e826861870a3c7cee623667dc7e1b92369dbd
Reviewed-on: https://chromium-review.googlesource.com/c/1298228
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602491}
[modify] https://crrev.com/d10cd0c15fcca20cb4347169cabb84fd9831241e/ui/views/controls/animated_image_view.cc

Sign in to add a comment