Make DevTools support SignedExchange error fallback |
||
Issue descriptionChrome Version: TOT Fallback redirection of signed exchange was implemented in crbug.com/874323 . But DevTools can't show the fallback redirection correctly yet. DevTools shows the redirected request in Network panel as if the response is the content of the signed exchange, even though the response was served from the server. Example: 1. Launch Chrome with "--enable-features=SignedHTTPExchange" flag. 2. Open DevTools Network tab. 3. Go "https://htxg-b1.appspot.com/sxg/hello_ec.sxg". 4. Chrome is redirected to "https://sxg-demo.horo.jp/hello_ec.html". 5. The page says "This file is served from the server. Not from SignedExchange." - "hello_ec.sxg" is signed with an invalid certificate without CanSignHttpExchangesDraft extension. So the request of "hello_ec.sxg" should be shown as error (with red color). - "hello_ec.html" is served from the server, not from the signed exchange. So: - The Size item of hello_ec.html in NetworkDataGrid should show the actual size, not "from signed-exchange". - The Status Code item of hello_ec.html in RequestHeadersView should say "signed-exchange error fallback" or something, not "from signed-exchange". Note: When AllowSignedHTTPExchangeCertsWithoutExtension feature is enabled, the certificate error is ignored, and the content "Hello SignedHTTPExchange" inside the signed exchange is rendered.
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36aebfaa13c3d5f40daff450a63d5245f5241fb5 commit 36aebfaa13c3d5f40daff450a63d5245f5241fb5 Author: Tsuyoshi Horo <horo@chromium.org> Date: Mon Oct 01 22:24:03 2018 Make DevTools support SignedExchange error fallback Bug: 890199 Change-Id: Idd9d01735d1a922692de63fc7b99e1154b13e7e9 Reviewed-on: https://chromium-review.googlesource.com/1250764 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595590} [modify] https://crrev.com/36aebfaa13c3d5f40daff450a63d5245f5241fb5/third_party/blink/renderer/devtools/front_end/network/NetworkDataGridNode.js [modify] https://crrev.com/36aebfaa13c3d5f40daff450a63d5245f5241fb5/third_party/blink/renderer/devtools/front_end/network/RequestHeadersView.js
,
Oct 3
|
||
►
Sign in to add a comment |
||
Comment 1 by horo@chromium.org
, Sep 28