New issue
Advanced search Search tips

Issue 890180 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SignedExchange: add timing breakdown UMAs

Project Member Reported by kouhei@chromium.org, Sep 28

Issue description

Add breakdown UMAs for time spent in various stages of SXG processing.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00fbc74ad4116d538edf3b59d032aa0ffbb0b642

commit 00fbc74ad4116d538edf3b59d032aa0ffbb0b642
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Tue Oct 02 08:54:16 2018

Add UMA for SignedExchange verification time

Bug: 890180
Change-Id: I3cedfd4b03b534eabeb9573c226123bd3d70068e
Reviewed-on: https://chromium-review.googlesource.com/1250686
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595766}
[modify] https://crrev.com/00fbc74ad4116d538edf3b59d032aa0ffbb0b642/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/00fbc74ad4116d538edf3b59d032aa0ffbb0b642/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcde0625a5825ffbb3628f71e70612a6c4ac8184

commit fcde0625a5825ffbb3628f71e70612a6c4ac8184
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Thu Oct 04 10:57:13 2018

Add UMA for SignedExchange certchain fetch cache hit

Bug: 890180
Change-Id: Iadafef53faba0cf2968b8c60da9503b28b116301
Reviewed-on: https://chromium-review.googlesource.com/c/1253314
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596580}
[modify] https://crrev.com/fcde0625a5825ffbb3628f71e70612a6c4ac8184/content/browser/web_package/signed_exchange_cert_fetcher.cc
[modify] https://crrev.com/fcde0625a5825ffbb3628f71e70612a6c4ac8184/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a58a983c4e83c6a67026962eae3b097a298c002

commit 8a58a983c4e83c6a67026962eae3b097a298c002
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Thu Oct 11 03:37:31 2018

SignedExchange: Notify SignedExchangePrefetchMetricRecorder when prefetch

After this CL, SignedExchangePrefetchHandler will notify SignedExchangePrefetchMetricRecorder
on SignedExchange prefetch start and finish.

Bug: 890180
Change-Id: I30109638a73630f41c97a4177ae6c1ac6aa0a238
Reviewed-on: https://chromium-review.googlesource.com/c/1263682
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598656}
[modify] https://crrev.com/8a58a983c4e83c6a67026962eae3b097a298c002/content/browser/BUILD.gn
[modify] https://crrev.com/8a58a983c4e83c6a67026962eae3b097a298c002/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/8a58a983c4e83c6a67026962eae3b097a298c002/content/browser/loader/prefetch_url_loader.cc
[modify] https://crrev.com/8a58a983c4e83c6a67026962eae3b097a298c002/content/browser/loader/prefetch_url_loader.h
[modify] https://crrev.com/8a58a983c4e83c6a67026962eae3b097a298c002/content/browser/loader/prefetch_url_loader_service.cc
[modify] https://crrev.com/8a58a983c4e83c6a67026962eae3b097a298c002/content/browser/loader/prefetch_url_loader_service.h
[modify] https://crrev.com/8a58a983c4e83c6a67026962eae3b097a298c002/content/browser/web_package/signed_exchange_loader.cc
[modify] https://crrev.com/8a58a983c4e83c6a67026962eae3b097a298c002/content/browser/web_package/signed_exchange_loader.h
[modify] https://crrev.com/8a58a983c4e83c6a67026962eae3b097a298c002/content/browser/web_package/signed_exchange_prefetch_handler.cc
[modify] https://crrev.com/8a58a983c4e83c6a67026962eae3b097a298c002/content/browser/web_package/signed_exchange_prefetch_handler.h
[add] https://crrev.com/8a58a983c4e83c6a67026962eae3b097a298c002/content/browser/web_package/signed_exchange_prefetch_metric_recorder.cc
[add] https://crrev.com/8a58a983c4e83c6a67026962eae3b097a298c002/content/browser/web_package/signed_exchange_prefetch_metric_recorder.h
[modify] https://crrev.com/8a58a983c4e83c6a67026962eae3b097a298c002/content/browser/web_package/signed_exchange_request_handler.cc
[modify] https://crrev.com/8a58a983c4e83c6a67026962eae3b097a298c002/content/browser/web_package/signed_exchange_request_handler.h

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97df84454db873390762a20012a30407d6bd1ed5

commit 97df84454db873390762a20012a30407d6bd1ed5
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Fri Oct 12 05:30:49 2018

Implement SignedExchange.Prefetch UMAs

Bug: 890180
Change-Id: I5de8d5b1bdb154455a59e5106ebcefd4973d5bcd
Reviewed-on: https://chromium-review.googlesource.com/c/1275746
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599103}
[modify] https://crrev.com/97df84454db873390762a20012a30407d6bd1ed5/content/browser/loader/prefetch_url_loader_service.cc
[modify] https://crrev.com/97df84454db873390762a20012a30407d6bd1ed5/content/browser/web_package/signed_exchange_loader.cc
[modify] https://crrev.com/97df84454db873390762a20012a30407d6bd1ed5/content/browser/web_package/signed_exchange_prefetch_metric_recorder.cc
[modify] https://crrev.com/97df84454db873390762a20012a30407d6bd1ed5/content/browser/web_package/signed_exchange_prefetch_metric_recorder.h
[add] https://crrev.com/97df84454db873390762a20012a30407d6bd1ed5/content/browser/web_package/signed_exchange_prefetch_metric_recorder_unittest.cc
[modify] https://crrev.com/97df84454db873390762a20012a30407d6bd1ed5/content/browser/web_package/signed_exchange_request_handler_browsertest.cc
[modify] https://crrev.com/97df84454db873390762a20012a30407d6bd1ed5/content/test/BUILD.gn
[modify] https://crrev.com/97df84454db873390762a20012a30407d6bd1ed5/tools/metrics/histograms/histograms.xml

Sign in to add a comment